MDL-34411 groups: copy/paste error in test_groups_user_groups_visible

This commit is contained in:
Shamim Rezaie 2019-06-14 15:48:52 +10:00 committed by Jenkins
parent ce1fd00203
commit cb64dfbeb1

View File

@ -1123,7 +1123,7 @@ class core_grouplib_testcase extends advanced_testcase {
* Tests for groups_user_groups_visible.
*/
public function test_groups_user_groups_visible() {
global $CFG, $DB;
global $DB;
$generator = $this->getDataGenerator();
$this->resetAfterTest();
@ -1172,7 +1172,8 @@ class core_grouplib_testcase extends advanced_testcase {
$result = groups_user_groups_visible($course, $user2->id);
$this->assertTrue($result);
$result = groups_user_groups_visible($course, $user2->id);
$cm->groupmode = NOGROUPS;
$result = groups_user_groups_visible($course, $user2->id, $cm);
$this->assertTrue($result); // Cm with no groups.
$cm->groupmode = SEPARATEGROUPS;
@ -1190,7 +1191,8 @@ class core_grouplib_testcase extends advanced_testcase {
$result = groups_user_groups_visible($course, $user2->id);
$this->assertTrue($result);
$result = groups_user_groups_visible($course, $user2->id);
$cm->groupmode = NOGROUPS;
$result = groups_user_groups_visible($course, $user2->id, $cm);
$this->assertTrue($result); // Cm with no groups.
$cm->groupmode = SEPARATEGROUPS;
@ -1228,7 +1230,7 @@ class core_grouplib_testcase extends advanced_testcase {
$this->assertTrue($result);
$cm->groupmode = NOGROUPS;
$result = groups_user_groups_visible($course, $user2->id);
$result = groups_user_groups_visible($course, $user2->id, $cm);
$this->assertTrue($result); // Cm with no groups.
$cm->groupmode = SEPARATEGROUPS;
@ -1296,7 +1298,8 @@ class core_grouplib_testcase extends advanced_testcase {
$result = groups_user_groups_visible($course, $user4->id);
$this->assertTrue($result);
$result = groups_user_groups_visible($course, $user4->id);
$cm->groupmode = NOGROUPS;
$result = groups_user_groups_visible($course, $user4->id, $cm);
$this->assertTrue($result); // Cm with no groups.
$cm->groupmode = SEPARATEGROUPS;
@ -1314,7 +1317,8 @@ class core_grouplib_testcase extends advanced_testcase {
$result = groups_user_groups_visible($course, $user4->id);
$this->assertTrue($result);
$result = groups_user_groups_visible($course, $user4->id);
$cm->groupmode = NOGROUPS;
$result = groups_user_groups_visible($course, $user4->id, $cm);
$this->assertTrue($result); // Cm with no groups.
$cm->groupmode = SEPARATEGROUPS;
@ -1322,7 +1326,7 @@ class core_grouplib_testcase extends advanced_testcase {
$this->assertTrue($result); // Cm with separate groups.
$cm->groupmode = SEPARATEGROUPS;
$result = groups_user_groups_visible($course, $user4->id);
$result = groups_user_groups_visible($course, $user4->id, $cm);
$this->assertTrue($result); // Cm with visible groups.
// Visible groups, forced.
@ -1352,7 +1356,7 @@ class core_grouplib_testcase extends advanced_testcase {
$this->assertTrue($result);
$cm->groupmode = NOGROUPS;
$result = groups_user_groups_visible($course, $user4->id);
$result = groups_user_groups_visible($course, $user4->id, $cm);
$this->assertTrue($result); // Cm with no groups.
$cm->groupmode = SEPARATEGROUPS;
@ -1424,7 +1428,8 @@ class core_grouplib_testcase extends advanced_testcase {
$result = groups_user_groups_visible($course, $user1->id);
$this->assertTrue($result); // Requesting all groups.
$result = groups_user_groups_visible($course, $user1->id);
$cm->groupmode = NOGROUPS;
$result = groups_user_groups_visible($course, $user1->id, $cm);
$this->assertTrue($result); // Cm with no groups.
$cm->groupmode = SEPARATEGROUPS;
@ -1446,7 +1451,8 @@ class core_grouplib_testcase extends advanced_testcase {
$result = groups_user_groups_visible($course, $user1->id);
$this->assertTrue($result); // Requesting all groups.
$result = groups_user_groups_visible($course, $user1->id);
$cm->groupmode = NOGROUPS;
$result = groups_user_groups_visible($course, $user1->id, $cm);
$this->assertTrue($result); // Cm with no groups.
$cm->groupmode = SEPARATEGROUPS;
@ -1456,7 +1462,7 @@ class core_grouplib_testcase extends advanced_testcase {
$this->assertTrue($result); // Cm with separate groups.
$cm->groupmode = SEPARATEGROUPS;
$result = groups_user_groups_visible($course, $user1->id);
$result = groups_user_groups_visible($course, $user1->id, $cm);
$this->assertTrue($result); // Cm with visible groups.
// Visible groups, forced.
@ -1492,7 +1498,7 @@ class core_grouplib_testcase extends advanced_testcase {
$this->assertTrue($result); // Requesting all groups.
$cm->groupmode = NOGROUPS;
$result = groups_user_groups_visible($course, $user1->id);
$result = groups_user_groups_visible($course, $user1->id, $cm);
$this->assertTrue($result); // Cm with no groups.
$cm->groupmode = SEPARATEGROUPS;