mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-22 17:02:03 +02:00
Code Issues Projects Releases Wiki Activity

MDL-49913 mod_lesson: fix import scores and jumps

Browse Source
This commit is contained in:
Jean-Michel Vedrine 2015-04-22 12:51:59 +02:00
parent 9fb9aa9c91
commit cb9d259dcd
1 changed files with 20 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
mod/lesson/format.php
View File

@ -103,6 +103,7 @@ function lesson_save_question_options($question, $lesson, $contextid) {
$answer = clone($defaultanswer);
if ($question->fraction[$key] >=0.5) {
$answer->jumpto = LESSON_NEXTPAGE;
$answer->score = 1;
}
$answer->grade = round($question->fraction[$key] * 100);
$answer->answer = $dataanswer;
@ -136,12 +137,14 @@ function lesson_save_question_options($question, $lesson, $contextid) {
foreach ($question->answer as $key => $dataanswer) {
if ($dataanswer != "") {
$answer = clone($defaultanswer);
$answer->jumpto = LESSON_NEXTPAGE;
if ($question->fraction[$key] >= 0.5) {
$answer->jumpto = LESSON_NEXTPAGE;
$answer->score = 1;
}
$answer->grade = round($question->fraction[$key] * 100);
$min = $question->answer[$key] - $question->tolerance[$key];
$max = $question->answer[$key] + $question->tolerance[$key];
$answer->answer = $min.":".$max;
// $answer->answer = $question->min[$key].":".$question->max[$key]; original line for min/max
$answer->response = $question->feedback[$key]['text'];
$answer->responseformat = $question->feedback[$key]['format'];
$answer->id = $DB->insert_record("lesson_answers", $answer);
@ -171,6 +174,7 @@ function lesson_save_question_options($question, $lesson, $contextid) {
$answer->grade = $question->correctanswer * 100;
if ($answer->grade > 50 ) {
$answer->jumpto = LESSON_NEXTPAGE;
$answer->score = 1;
}
if (isset($question->feedbacktrue)) {
$answer->response = $question->feedbacktrue['text'];
@ -185,6 +189,7 @@ function lesson_save_question_options($question, $lesson, $contextid) {
$answer->grade = (1 - (int)$question->correctanswer) * 100;
if ($answer->grade > 50 ) {
$answer->jumpto = LESSON_NEXTPAGE;
$answer->score = 1;
}
if (isset($question->feedbackfalse)) {
$answer->response = $question->feedbackfalse['text'];
@ -207,17 +212,19 @@ function lesson_save_question_options($question, $lesson, $contextid) {
if ($dataanswer != "") {
$answer = clone($defaultanswer);
$answer->grade = round($question->fraction[$key] * 100);
// changed some defaults
/* Original Code
if ($answer->grade > 50 ) {
$answer->jumpto = LESSON_NEXTPAGE;
if ($question->single) {
if ($answer->grade > 50) {
$answer->jumpto = LESSON_NEXTPAGE;
$answer->score = 1;
}
} else {
// If multi answer allowed, any answer with fraction > 0 is considered correct.
if ($question->fraction[$key] > 0) {
$answer->jumpto = LESSON_NEXTPAGE;
$answer->score = 1;
}
}
Replaced with: */
if ($answer->grade > 50 ) {
$answer->jumpto = LESSON_NEXTPAGE;
$answer->score = 1;
}
// end Replace
$answer->answer = $dataanswer['text'];
$answer->answerformat = $dataanswer['format'];
$answer->response = $question->feedback[$key]['text'];
@ -261,6 +268,7 @@ function lesson_save_question_options($question, $lesson, $contextid) {
$correctanswer = clone($defaultanswer);
$correctanswer->answer = get_string('thatsthecorrectanswer', 'lesson');
$correctanswer->jumpto = LESSON_NEXTPAGE;
$correctanswer->score = 1;
$DB->insert_record("lesson_answers", $correctanswer);
// The second answer should always be the wrong answer