mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-14 20:50:21 +01:00
Code Issues Projects Releases Wiki Activity

Merge branch 'MDL-73010' of https://github.com/paulholden/moodle

Browse Source
This commit is contained in:
Huong Nguyen 2024-02-01 10:49:28 +07:00
commit cc02940ddb
2 changed files with 52 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
repository/filesystem/lib.php
View File

@ -99,7 +99,7 @@ class repository_filesystem extends repository {
$fileslist = array();
$dirslist = array();
if ($dh = opendir($abspath)) {
while (($file = readdir($dh)) != false) {
while (false !== ($file = readdir($dh))) {
if ($file != '.' and $file != '..') {
if (is_file($abspath . $file)) {
$fileslist[] = $file;
@ -108,6 +108,7 @@ class repository_filesystem extends repository {
}
}
}
closedir($dh);
}
core_collator::asort($fileslist, core_collator::SORT_NATURAL);
core_collator::asort($dirslist, core_collator::SORT_NATURAL);

50
repository/filesystem/tests/repository_filesystem_test.php Normal file
View File

@ -0,0 +1,50 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* Tests for the repository_filesystem plugin.
*
* @package repository_filesystem
* @copyright 2024 Andrew Lyons <andrew@nicols.co.uk>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
* @covers \repository_filesystem
*/
class repository_filesystem_test extends \advanced_testcase {
public function test_get_listing(): void {
global $CFG;
$this->resetAfterTest(true);
$user = get_admin();
$this->setUser($user);
$this->getDataGenerator()->create_repository_type('filesystem');
mkdir($CFG->dataroot . '/repository/test/0', recursive: true);
file_put_contents($CFG->dataroot . '/repository/test/0/test.txt', 'test');
$record = $this->getDataGenerator()->create_repository('filesystem', [
'fs_path' => 'test',
]);
/** @var repository_filesystem $repository */
$repository = repository::get_repository_by_id($record->id, \core\context\user::instance($user->id));
$listing = $repository->get_listing();
$this->assertCount(1, $listing['list']);
$this->assertEquals(['0'], array_column($listing['list'], 'title'));
}
}