mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-21 08:00:37 +01:00
Code Issues Projects Releases Wiki Activity

MDL-66298 forumreport_summary: Moved table generation out of renderer

Browse Source 
Part of MDL-66076.
This commit is contained in:
Shamim Rezaie 2019-09-27 23:23:07 +10:00 committed by Jun Pataleta
parent 8ffe06b9aa
commit cc97038258
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mod/forum/report/summary/index.php
View File

@ -84,6 +84,8 @@ $renderer = $PAGE->get_renderer('forumreport_summary');
echo $renderer->render_filters_form($cm, $url, $filters);
// Prepare and display the report.
echo $renderer->render_report($courseid, $url, $filters, $perpage);
$table = new \forumreport_summary\summary_table($courseid, $filters);
$table->baseurl = $url;
echo $renderer->render_summary_table($table, $perpage);
echo $OUTPUT->footer();

12
mod/forum/report/summary/renderer.php
View File

@ -24,6 +24,8 @@
defined('MOODLE_INTERNAL') || die();
use forumreport_summary\summary_table;
/**
* Renderer for the forum summary report.
*
@ -50,17 +52,11 @@ class forumreport_summary_renderer extends plugin_renderer_base {
/**
* Render the summary report table.
*
* @param int $courseid ID of the course where the forum is located.
* @param string $url Base URL for the report page.
* @param array $filters Values of filters to be applied.
* @param summary_table $table The summary table to be rendered.
* @param int $perpage Number of results to render per page.
* @return string The report table HTML.
*/
public function render_report($courseid, $url, $filters, $perpage) {
// Initialise table.
$table = new \forumreport_summary\summary_table($courseid, $filters);
$table->baseurl = $url;
public function render_summary_table(summary_table $table, int $perpage): string {
// Buffer so calling script can output the report as required.
ob_start();