mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-17 21:49:15 +01:00
Code Issues Projects Releases Wiki Activity

MDL-71636 qbank_columnsortorder: unit and behat test fix

Browse Source
This commit is contained in:
Safat Shahin 2022-03-03 01:03:09 +11:00 committed by Marc-Alexandre Ghaly
parent bdedb3f9c9
commit cceabf651f
3 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
question/bank/columnsortorder/tests/behat/columnsortorder.feature
View File

@ -1,4 +1,4 @@
@core @qbank_columnsortorder @javascript
@qbank @qbank_columnsortorder @javascript
Feature: An plugin column can be reordered and displayed in the question bank view.
In order to reorganise the question bank view columns
As an admin
@ -25,27 +25,24 @@ Feature: An plugin column can be reordered and displayed in the question bank vi
| questioncategory | qtype | name | user | questiontext | idnumber |
| Question category 1 | essay | Test question to be seen | teacher1 | Write about whatever you want | idnumber1 |
@javascript
Scenario: Teacher can see proper view
Given I am on the "Test quiz Q001" "quiz activity" page logged in as "teacher1"
When I navigate to "Question bank > Questions" in current page administration
When I navigate to "Question bank" in current page administration
And I click on "category" "select"
And I click on "Question category 1" "option"
And I should see "Test question to be seen"
Then I should see "Teacher 1"
@javascript
Scenario: Reordering question bank columns
Given I log in as "admin"
When I navigate to "Plugins > Question bank plugins > Column sort order" in site administration
And I drag "Created by (creator_name_column)" "text" and I drop it in "T (question_type_column)" "text"
And I am on the "Test quiz Q001" "quiz activity" page logged in as "teacher1"
And I navigate to "Question bank > Questions" in current page administration
And I navigate to "Question bank" in current page administration
And I click on "category" "select"
And I click on "Question category 1" "option"
Then ".creatorname" "css_element" should appear before ".qtype" "css_element"
@javascript
Scenario: Disabling and enabling column display is proper
Given I log in as "admin"
When I navigate to "Plugins > Question bank plugins > Column sort order" in site administration
@ -61,7 +58,6 @@ Feature: An plugin column can be reordered and displayed in the question bank vi
Then I should not see "Columns below are currently disabled."
And I should see "Created by (creator_name_column)"
@javascript
Scenario: Custom fields are reorderable
Given I log in as "admin"
When I navigate to "Plugins > Question bank plugins > Question custom fields" in site administration
@ -75,6 +71,7 @@ Feature: An plugin column can be reordered and displayed in the question bank vi
Then I should see "checkboxcustomcolumn"
And I navigate to "Plugins > Question bank plugins > Column sort order" in site administration
And I should see "checkboxcustomcolumn"
And I change the window size to "large"
And I drag "checkboxcustomcolumn" "text" and I drop it in "T (question_type_column)" "text"
Then "checkboxcustomcolumn" "text" should appear before "T (question_type_column)" "text"
And I click on "Manage question bank plugins" "link"

9
question/bank/columnsortorder/tests/external/columnsortorder_external_test.php vendored
View File

@ -50,14 +50,11 @@ class columnsortorder_external_test extends advanced_testcase {
$columnclasses[] = $columnnobject->class;
}
shuffle($columnclasses);
$columnclasses = implode(',', $columnclasses);
set_columnbank_order::execute($columnclasses);
$currentconfig = (array)get_config('qbank_columnsortorder');
unset($currentconfig['version']);
asort($currentconfig);
$currentconfig = array_flip($currentconfig);
$columnclasses = explode(',', $columnclasses);
$currentconfig = (array)get_config('qbank_columnsortorder', 'enabledcol');
$currentconfig = explode(',', $currentconfig[0]);
$this->assertSame($columnclasses, $currentconfig);
}
}

2
question/bank/history/classes/version_number_column.php
View File

@ -32,7 +32,7 @@ class version_number_column extends column_base {
return 'questionversionnumber';
}
protected function get_title(): string {
public function get_title(): string {
return get_string('questionversionnumber', 'qbank_history');
}