mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-07-27 17:30:53 +02:00
Code Issues Projects Releases Wiki Activity

MDL-41082 navigation: Remove unnecessary load of portfolio instances

Browse Source
This commit is contained in:
Frederic Massart
2013-08-08 10:20:56 +08:00
parent 50ff861263
commit ce4619be9b
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/navigationlib.php
View File

@@ -4049,7 +4049,7 @@ class settings_navigation extends navigation_node {
// Portfolio // Portfolio
if ($currentuser && !empty($CFG->enableportfolios) && has_capability('moodle/portfolio:export', $systemcontext)) { if ($currentuser && !empty($CFG->enableportfolios) && has_capability('moodle/portfolio:export', $systemcontext)) {
require_once($CFG->libdir . '/portfoliolib.php'); require_once($CFG->libdir . '/portfoliolib.php');
if (portfolio_instances(true, false)) { if (portfolio_has_visible_instances()) {
$portfolio = $usersetting->add(get_string('portfolios', 'portfolio'), null, self::TYPE_SETTING); $portfolio = $usersetting->add(get_string('portfolios', 'portfolio'), null, self::TYPE_SETTING);
$url = new moodle_url('/user/portfolio.php', array('courseid'=>$course->id)); $url = new moodle_url('/user/portfolio.php', array('courseid'=>$course->id));

10
lib/portfoliolib.php
View File

@@ -533,6 +533,16 @@ function portfolio_instances($visibleonly=true, $useronly=true) {
return $instances; return $instances;
} }
/**
* Return whether there are visible instances in portfolio.
*
* @return bool true when there are some visible instances.
*/
function portfolio_has_visible_instances() {
global $DB;
return $DB->record_exists('portfolio_instance', array('visible' => 1));
}
/** /**
* Supported formats currently in use. * Supported formats currently in use.
* Canonical place for a list of all formats * Canonical place for a list of all formats