mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 22:08:20 +01:00
Code Issues Projects Releases Wiki Activity

MDL-46571 gradereport_history: Unit tests for the table_sql results

Browse Source 
Part of MDL-46191
This commit is contained in:
Frederic Massart 2014-08-08 10:51:22 +08:00 committed by Ankit Agarwal
parent a347687b79
commit cf6bc1b1a2
2 changed files with 237 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
grade/report/history/classes/output/tablelog.php
View File

@ -70,8 +70,8 @@ class tablelog extends \table_sql implements \renderable {
* @param \context_course $context Context of the report.
* @param \moodle_url $url url of the page where this table would be displayed.
* @param array $filters options are:
* users : limit to specific users (default: none)
* gradeitem : limit to specific item (default: all)
* userids : limit to specific users (default: none)
* itemid : limit to specific grade item (default: all)
* grader : limit to specific graders (default: all)
* datefrom : start of date range
* datetill : end of date range

235
grade/report/history/tests/report_test.php Normal file
View File

@ -0,0 +1,235 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* Grade history report test.
*
* @package gradereport_history
* @copyright 2014 Frédéric Massart - FMCorz.net
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
defined('MOODLE_INTERNAL') || die();
/**
* Grade history report test class.
*
* @package gradereport_history
* @copyright 2014 Frédéric Massart - FMCorz.net
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class gradereport_history_report_testcase extends advanced_testcase {
/**
* Create some grades.
*/
public function test_query_db() {
$this->resetAfterTest();
// Making the setup.
$c1 = $this->getDataGenerator()->create_course();
$c2 = $this->getDataGenerator()->create_course();
$c1ctx = context_course::instance($c1->id);
$c2ctx = context_course::instance($c2->id);
// Users.
$u1 = $this->getDataGenerator()->create_user();
$u2 = $this->getDataGenerator()->create_user();
$u3 = $this->getDataGenerator()->create_user();
$u4 = $this->getDataGenerator()->create_user();
$u5 = $this->getDataGenerator()->create_user();
$grader1 = $this->getDataGenerator()->create_user();
$grader2 = $this->getDataGenerator()->create_user();
// Modules.
$c1m1 = $this->getDataGenerator()->create_module('assign', array('course' => $c1));
$c1m2 = $this->getDataGenerator()->create_module('assign', array('course' => $c1));
$c1m3 = $this->getDataGenerator()->create_module('assign', array('course' => $c1));
$c2m1 = $this->getDataGenerator()->create_module('assign', array('course' => $c2));
// Creating fake history data.
$giparams = array('itemtype' => 'mod', 'itemmodule' => 'assign');
$grades = array();
$gi = grade_item::fetch($giparams + array('iteminstance' => $c1m1->id));
$grades['c1m1u1'] = $this->create_grade_history(array('itemid' => $gi->id, 'userid' => $u1->id,
'timemodified' => time() - 3600));
$grades['c1m1u2'] = $this->create_grade_history(array('itemid' => $gi->id, 'userid' => $u2->id,
'timemodified' => time() + 3600));
$grades['c1m1u3'] = $this->create_grade_history(array('itemid' => $gi->id, 'userid' => $u3->id));
$grades['c1m1u4'] = $this->create_grade_history(array('itemid' => $gi->id, 'userid' => $u4->id));
$grades['c1m1u5'] = $this->create_grade_history(array('itemid' => $gi->id, 'userid' => $u5->id));
$gi = grade_item::fetch($giparams + array('iteminstance' => $c1m2->id));
$grades['c1m2u1'] = $this->create_grade_history(array('itemid' => $gi->id, 'userid' => $u1->id));
$grades['c1m2u2'] = $this->create_grade_history(array('itemid' => $gi->id, 'userid' => $u2->id));
$gi = grade_item::fetch($giparams + array('iteminstance' => $c1m3->id));
$grades['c1m3u1'] = $this->create_grade_history(array('itemid' => $gi->id, 'userid' => $u1->id));
$gi = grade_item::fetch($giparams + array('iteminstance' => $c2m1->id));
$grades['c2m1u1'] = $this->create_grade_history(array('itemid' => $gi->id, 'userid' => $u1->id,
'usermodified' => $grader1->id));
$grades['c2m1u2'] = $this->create_grade_history(array('itemid' => $gi->id, 'userid' => $u2->id,
'usermodified' => $grader1->id));
$grades['c2m1u3'] = $this->create_grade_history(array('itemid' => $gi->id, 'userid' => $u3->id,
'usermodified' => $grader1->id));
$grades['c2m1u4'] = $this->create_grade_history(array('itemid' => $gi->id, 'userid' => $u4->id,
'usermodified' => $grader2->id));
// Histories where grades have not been revised..
$grades['c2m1u5'] = $this->create_grade_history(array('itemid' => $gi->id, 'userid' => $u5->id,
'timemodified' => time() - 60));
$grades['c2m1u5'] = $this->create_grade_history(array('itemid' => $gi->id, 'userid' => $u5->id,
'timemodified' => time()));
$grades['c2m1u5'] = $this->create_grade_history(array('itemid' => $gi->id, 'userid' => $u5->id,
'timemodified' => time() + 60));
// TODO MDL-46737 Handle deleted/non-existing grade items.
// Histories with missing grade items, considered as deleted.
// $grades['c2x1u5'] = $this->create_grade_history($giparams + array('itemid' => -1, 'userid' => $u5->id, 'courseid' => $c1->id));
// $grades['c2x2u5'] = $this->create_grade_history($giparams + array('itemid' => 999999, 'userid' => $u5->id, 'courseid' => $c1->id));
// Basic filtering based on course id.
$this->assertEquals(8, $this->get_tablelog_results($c1ctx, array(), true));
$this->assertEquals(7, $this->get_tablelog_results($c2ctx, array(), true));
// Filtering on 1 user.
$this->assertEquals(3, $this->get_tablelog_results($c1ctx, array('userids' => $u1->id), true));
// Filtering on more users.
$this->assertEquals(4, $this->get_tablelog_results($c1ctx, array('userids' => "$u1->id,$u3->id"), true));
// Filtering based on one grade item.
$gi = grade_item::fetch($giparams + array('iteminstance' => $c1m1->id));
$this->assertEquals(5, $this->get_tablelog_results($c1ctx, array('itemid' => $gi->id), true));
$gi = grade_item::fetch($giparams + array('iteminstance' => $c1m3->id));
$this->assertEquals(1, $this->get_tablelog_results($c1ctx, array('itemid' => $gi->id), true));
// Filtering based on the grader.
$this->assertEquals(3, $this->get_tablelog_results($c2ctx, array('grader' => $grader1->id), true));
$this->assertEquals(1, $this->get_tablelog_results($c2ctx, array('grader' => $grader2->id), true));
// Filtering based on date.
$results = $this->get_tablelog_results($c1ctx, array('datefrom' => time() + 1800));
$this->assertGradeHistoryIds(array($grades['c1m1u2']->id), $results);
$results = $this->get_tablelog_results($c1ctx, array('datetill' => time() - 1800));
$this->assertGradeHistoryIds(array($grades['c1m1u1']->id), $results);
$results = $this->get_tablelog_results($c1ctx, array('datefrom' => time() - 1800, 'datetill' => time() + 1800));
$this->assertGradeHistoryIds(array($grades['c1m1u3']->id, $grades['c1m1u4']->id, $grades['c1m1u5']->id,
$grades['c1m2u1']->id, $grades['c1m2u2']->id, $grades['c1m3u1']->id), $results);
// Filtering based on revised only.
$this->assertEquals(3, $this->get_tablelog_results($c2ctx, array('userids' => $u5->id), true));
$this->assertEquals(1, $this->get_tablelog_results($c2ctx, array('userids' => $u5->id, 'revisedonly' => true), true));
}
/**
* Asserts that the array of grade objects contains exactly the right IDs.
*
* @param array $expectedids Array of expected IDs.
* @param array $objects Array of objects returned by the table.
*/
protected function assertGradeHistoryIds(array $expectedids, array $objects) {
$this->assertCount(count($expectedids), $objects);
$expectedids = array_flip($expectedids);
foreach ($objects as $object) {
$this->assertArrayHasKey($object->id, $expectedids);
unset($expectedids[$object->id]);
}
$this->assertCount(0, $expectedids);
}
/**
* Create a new grade history entry.
*
* @param array $params Of values.
* @return object The grade object.
*/
protected function create_grade_history($params) {
global $DB;
$params = (array) $params;
if (!isset($params['itemid'])) {
throw new coding_exception('Missing itemid key.');
}
if (!isset($params['userid'])) {
throw new coding_exception('Missing userid key.');
}
// Default object.
$grade = new stdClass();
$grade->itemid = 0;
$grade->userid = 0;
$grade->oldid = 123;
$grade->rawgrade = 50;
$grade->finalgrade = 50;
$grade->timecreated = time();
$grade->timemodified = time();
$grade->information = '';
$grade->informationformat = FORMAT_PLAIN;
$grade->feedback = '';
$grade->feedbackformat = FORMAT_PLAIN;
$grade->usermodified = 2;
// Merge with data passed.
$grade = (object) array_merge((array) $grade, $params);
// Insert record.
$grade->id = $DB->insert_record('grade_grades_history', $grade);
return $grade;
}
/**
* Returns a table log object.
*
* @param context_course $coursecontext The course context.
* @param array $filters An array of filters.
* @param boolean $count When true, returns a count rather than an array of objects.
* @return mixed Count or array of objects.
*/
protected function get_tablelog_results($coursecontext, $filters = array(), $count = false) {
$table = new gradereport_history_tests_tablelog('something', $coursecontext, new moodle_url(''), $filters);
return $table->get_test_results($count);
}
}
/**
* Extended table log class.
*/
class gradereport_history_tests_tablelog extends \gradereport_history\output\tablelog {
/**
* Get the test results.
*
* @param boolean $count Whether or not we want the count.
* @return mixed Count or array of objects.
*/
public function get_test_results($count = false) {
global $DB;
if ($count) {
list($sql, $params) = $this->get_sql_and_params(true);
return $DB->count_records_sql($sql, $params);
} else {
$this->setup();
list($sql, $params) = $this->get_sql_and_params();
return $DB->get_records_sql($sql, $params);
}
}
}