mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-20 07:56:06 +02:00
Code Issues Projects Releases Wiki Activity

Added Petri's patch that allows us to finally change type of PostgreSQL columns!

Browse Source 
Yay!   Thanks, Petri!

Bug 1721
This commit is contained in:
moodler 2004-08-09 16:00:10 +00:00
parent 518f01ce4f
commit d05024a72b
1 changed files with 19 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
lib/datalib.php
View File

@ -136,7 +136,8 @@ function table_column($table, $oldfield, $field, $type="integer", $size="10",
$dbver = substr($dbinfo['version'],0,3);
//to prevent conflicts with reserved words
$field = "\"$field\"";
$realfield = "\"$field\"";
$field = "\"${field}_alter_column_tmp\"";
$oldfield = "\"$oldfield\"";
switch (strtolower($type)) {
@ -163,14 +164,14 @@ function table_column($table, $oldfield, $field, $type="integer", $size="10",
// $after = "AFTER '$after'";
//}
if ($oldfield != "\"\"") {
if ($field != $oldfield) {
execute_sql("ALTER TABLE {$CFG->prefix}$table RENAME COLUMN $oldfield TO $field");
}
} else {
execute_sql("ALTER TABLE {$CFG->prefix}$table ADD COLUMN $field $type");
execute_sql("UPDATE {$CFG->prefix}$table SET $field=$default");
}
//Use transactions
execute_sql("BEGIN");
//Allways use temporaly column
execute_sql("ALTER TABLE {$CFG->prefix}$table ADD COLUMN $field $type");
//Add default values
execute_sql("UPDATE {$CFG->prefix}$table SET $field=$default");
if ($dbver >= "7.3") {
// modifying 'not null' is posible before 7.3
@ -183,8 +184,16 @@ function table_column($table, $oldfield, $field, $type="integer", $size="10",
}
}
return execute_sql("ALTER TABLE {$CFG->prefix}$table ALTER COLUMN $field SET DEFAULT $default");
execute_sql("ALTER TABLE {$CFG->prefix}$table ALTER COLUMN $field SET DEFAULT $default");
if ( $oldfield != "\"\"" ) {
execute_sql("UPDATE {$CFG->prefix}$table SET $field = $oldfield");
execute_sql("ALTER TABLE {$CFG->prefix}$table drop column $oldfield");
}
execute_sql("ALTER TABLE {$CFG->prefix}$table RENAME COLUMN $field TO $realfield");
return execute_sql("COMMIT");
break;
default: