mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-78619 theme: Communication button fixes

Browse Source 
The footer button was missing some CSS to factor in the blocks drawer.
Also added noreferrer to the window.open call made when clicking the
communication button, to avoid the risks associated with opening in
_blank without removing access to the referrer and opener (noopener is
implicitly defined in modern browsers when noreferrer is set).
This commit is contained in:
Michael Hawkins 2023-07-26 19:38:31 +08:00
parent a3fa3e3fc1
commit d0fe8d4c21
No known key found for this signature in database
GPG Key ID: 81FCB1395B8AA779
5 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
theme/boost/scss/moodle/drawer.scss
View File

@ -47,7 +47,8 @@ $drawer-bg: darken($body-bg, 5%) !default;
[data-region="drawer"] {
padding: $drawer-padding-x $drawer-padding-y;
}
.jsenabled .btn-footer-popover {
.jsenabled .btn-footer-popover,
.jsenabled .btn-footer-communication {
@include transition(0.2s);
}
}

3
theme/boost/scss/moodle/layout.scss
View File

@ -228,7 +228,8 @@
margin-left: 0;
margin-right: $drawer-right-width;
padding-right: 1rem;
.jsenabled & .btn-footer-popover {
.jsenabled & .btn-footer-popover,
.jsenabled & .btn-footer-communication {
right: calc(#{$drawer-right-width} + 2rem);
}
}

8
theme/boost/style/moodle.css
View File

@ -29610,12 +29610,14 @@ span.editinstructions .alert-link {
[data-region=drawer] {
padding: 20px 20px;
}
.jsenabled .btn-footer-popover {
.jsenabled .btn-footer-popover,
.jsenabled .btn-footer-communication {
transition: 0.2s;
}
}
@media (min-width: 576px) and (prefers-reduced-motion: reduce) {
.jsenabled .btn-footer-popover {
.jsenabled .btn-footer-popover,
.jsenabled .btn-footer-communication {
transition: none;
}
}
@ -36666,7 +36668,7 @@ span[data-flexitour=container][x-placement=right] div[data-role=arrow]:after, sp
margin-right: 315px;
padding-right: 1rem;
}
.jsenabled #page.drawers.show-drawer-right .btn-footer-popover {
.jsenabled #page.drawers.show-drawer-right .btn-footer-popover, .jsenabled #page.drawers.show-drawer-right .btn-footer-communication {
right: calc(315px + 2rem);
}
}

2
theme/boost/templates/footer.mustache
View File

@ -38,7 +38,7 @@
<footer id="page-footer" class="footer-popover bg-white">
<div data-region="footer-container-popover">
{{#output.has_communication_links}}
<button onclick="window.open('{{output.communication_url}}', '_blank')" class="btn btn-icon bg-primary text-white icon-no-margin btn-footer-communication" aria-label="{{#str}}communicationroomlink, course{{/str}}">
<button onclick="window.open('{{output.communication_url}}', '_blank', 'noreferrer')" class="btn btn-icon bg-primary text-white icon-no-margin btn-footer-communication" aria-label="{{#str}}communicationroomlink, course{{/str}}">
{{#pix}}t/messages-o, core{{/pix}}
</button>
{{/output.has_communication_links}}

8
theme/classic/style/moodle.css
View File

@ -29610,12 +29610,14 @@ span.editinstructions .alert-link {
[data-region=drawer] {
padding: 20px 20px;
}
.jsenabled .btn-footer-popover {
.jsenabled .btn-footer-popover,
.jsenabled .btn-footer-communication {
transition: 0.2s;
}
}
@media (min-width: 576px) and (prefers-reduced-motion: reduce) {
.jsenabled .btn-footer-popover {
.jsenabled .btn-footer-popover,
.jsenabled .btn-footer-communication {
transition: none;
}
}
@ -36600,7 +36602,7 @@ span[data-flexitour=container][x-placement=right] div[data-role=arrow]:after, sp
margin-right: 315px;
padding-right: 1rem;
}
.jsenabled #page.drawers.show-drawer-right .btn-footer-popover {
.jsenabled #page.drawers.show-drawer-right .btn-footer-popover, .jsenabled #page.drawers.show-drawer-right .btn-footer-communication {
right: calc(315px + 2rem);
}
}