From 6c4813589671f2c2e7baf8ee9b1a9cd08c1f0e37 Mon Sep 17 00:00:00 2001
From: Marina Glancy <marina@moodle.com>
Date: Thu, 20 Apr 2017 13:42:07 +0800
Subject: [PATCH] MDL-58138 completion: mform wants 0-based indexes for arrays

---
 completion/classes/bulkedit_form.php  | 6 ++++--
 completion/tests/bulk_update_test.php | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/completion/classes/bulkedit_form.php b/completion/classes/bulkedit_form.php
index d9eadee0025..a67cce75f69 100644
--- a/completion/classes/bulkedit_form.php
+++ b/completion/classes/bulkedit_form.php
@@ -100,9 +100,11 @@ class core_completion_bulkedit_form extends core_completion_edit_base_form {
 
         $mform = $this->_form;
 
+        $idx = 0;
         foreach ($this->cms as $cm) {
-            $mform->addElement('hidden', 'cmid['.$cm->id.']', $cm->id);
-            $mform->setType('cmid['.$cm->id.']', PARAM_INT);
+            $mform->addElement('hidden', 'cmid['.$idx.']', $cm->id);
+            $mform->setType('cmid['.$idx.']', PARAM_INT);
+            $idx++;
         }
 
         parent::definition();
diff --git a/completion/tests/bulk_update_test.php b/completion/tests/bulk_update_test.php
index b7e4c993c17..69dcd09129d 100644
--- a/completion/tests/bulk_update_test.php
+++ b/completion/tests/bulk_update_test.php
@@ -254,11 +254,13 @@ class core_completion_bulk_update_testcase extends advanced_testcase {
             $cmrec = $DB->get_record('course_modules', ['id' => $cm->id]);
             $instancerec = $DB->get_record($cm->modname, ['id' => $cm->instance]);
             foreach ($cmdata as $key => $value) {
-                $this->assertEquals($value, $cmrec->$key);
+                $this->assertEquals($value, $cmrec->$key, 'Error asserting that value for the field ' . $key.' ' .
+                    $cmrec->$key . ' matches expected value ' . $value);
             }
             if ($instancedata) {
                 foreach ($instancedata[$cnt] as $key => $value) {
-                    $this->assertEquals($value, $instancerec->$key);
+                    $this->assertEquals($value, $instancerec->$key, 'Error asserting that value for the field ' . $key . ' '.
+                        $instancerec->$key . ' matches expected value ' . $value);
                 }
             }
             $cnt++;