mirror of
https://github.com/moodle/moodle.git
synced 2025-04-14 13:02:07 +02:00
MDL-47077 report_participation: fixed pagination in groups
This commit is contained in:
parent
b49de5d930
commit
d5ae34a5a7
@ -37,7 +37,7 @@ $timefrom = optional_param('timefrom', 0, PARAM_INT); // how far back to look.
|
||||
$action = optional_param('action', '', PARAM_ALPHA);
|
||||
$page = optional_param('page', 0, PARAM_INT); // which page to show
|
||||
$perpage = optional_param('perpage', DEFAULT_PAGE_SIZE, PARAM_INT); // how many per page
|
||||
$currentgroup = optional_param('group', 0, PARAM_INT); // Get the active group.
|
||||
$currentgroup = optional_param('group', null, PARAM_INT); // Get the active group.
|
||||
|
||||
$url = new moodle_url('/report/participation/index.php', array('id'=>$id));
|
||||
if ($roleid !== 0) $url->param('roleid');
|
||||
@ -128,8 +128,15 @@ if ($onlyuselegacyreader) {
|
||||
// Print first controls.
|
||||
report_participation_print_filter_form($course, $timefrom, $minlog, $action, $roleid, $instanceid);
|
||||
|
||||
$baseurl = $CFG->wwwroot.'/report/participation/index.php?id='.$course->id.'&roleid='
|
||||
.$roleid.'&instanceid='.$instanceid.'&timefrom='.$timefrom.'&action='.$action.'&perpage='.$perpage;
|
||||
$baseurl = new moodle_url('/report/participation/index.php', array(
|
||||
'id' => $course->id,
|
||||
'roleid' => $roleid,
|
||||
'instanceid' => $instanceid,
|
||||
'timefrom' => $timefrom,
|
||||
'action' => $action,
|
||||
'perpage' => $perpage,
|
||||
'group' => $currentgroup
|
||||
));
|
||||
$select = groups_allgroups_course_menu($course, $baseurl, true, $currentgroup);
|
||||
|
||||
// User cannot see any group.
|
||||
@ -341,10 +348,15 @@ if (!empty($instanceid) && !empty($roleid)) {
|
||||
$table->print_html();
|
||||
|
||||
if ($perpage == SHOW_ALL_PAGE_SIZE) {
|
||||
echo '<div id="showall"><a href="'.$baseurl.'&perpage='.DEFAULT_PAGE_SIZE.'">'.get_string('showperpage', '', DEFAULT_PAGE_SIZE).'</a></div>'."\n";
|
||||
}
|
||||
else if ($matchcount > 0 && $perpage < $matchcount) {
|
||||
echo '<div id="showall"><a href="'.$baseurl.'&perpage='.SHOW_ALL_PAGE_SIZE.'">'.get_string('showall', '', $matchcount).'</a></div>'."\n";
|
||||
$perpageurl = new moodle_url($baseurl, array('perpage' => DEFAULT_PAGE_SIZE));
|
||||
echo html_writer::start_div('', array('id' => 'showall'));
|
||||
echo html_writer::link($perpageurl, get_string('showperpage', '', DEFAULT_PAGE_SIZE));
|
||||
echo html_writer::end_div();
|
||||
} else if ($matchcount > 0 && $perpage < $matchcount) {
|
||||
$perpageurl = new moodle_url($baseurl, array('perpage' => SHOW_ALL_PAGE_SIZE));
|
||||
echo html_writer::start_div('', array('id' => 'showall'));
|
||||
echo html_writer::link($perpageurl, get_string('showall', '', $matchcount));
|
||||
echo html_writer::end_div();
|
||||
}
|
||||
|
||||
echo '<div class="selectbuttons">';
|
||||
|
Loading…
x
Reference in New Issue
Block a user