mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-22 08:55:15 +02:00
Code Issues Projects Releases Wiki Activity

MDL-81872 course: Coding style improvements

Browse Source
This commit is contained in:
Andrew Nicols 2024-05-28 09:25:39 +08:00
parent 455cdd8c5b
commit d6d795cd0f
No known key found for this signature in database
GPG Key ID: 6D1E3157C8CFBF14
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.upgradenotes/MDL-81872-2024052707330838.yml
View File

@ -2,7 +2,7 @@ issueNumber: MDL-81872
notes:
core_course:
- message: >+
The reset course page has been improved. The "Delete" or "Remove" wording have been removed from all the options to make it easier to focus on the data to be removed and avoid inconsistencies and duplicated information.
The reset course page has been improved. The words "Delete" and "Remove" have been removed from all the options to make it easier to focus on the data to be removed and avoid inconsistencies and duplicated information.
Third party plugins implementing reset methods might need to:
- Add static element in the _reset_course_form_definition method before all the options with the Delete string:

6
course/reset.php
View File

@ -84,9 +84,9 @@ if ($mform->is_cancelled()) {
if ($item['error'] === false) {
$line[] = get_string('statusdone');
} else {
$line[] = '<div class="text-danger">' .
$OUTPUT->pix_icon('i/invalid', get_string('error')) . $item['error'] .
'</div>';
$line[] = html_writer::div(
$OUTPUT->pix_icon('i/invalid', get_string('error')) . $item['error'],
);
}
$data[] = $line;
}