From d784e19d9bb90ede7741e265a6b3169f49485b87 Mon Sep 17 00:00:00 2001 From: Andrew Nicols Date: Thu, 2 Mar 2023 11:05:54 +0800 Subject: [PATCH] MDL-77461 behat: Use get_course_id instead of DB fetch --- lib/tests/behat/behat_navigation.php | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/lib/tests/behat/behat_navigation.php b/lib/tests/behat/behat_navigation.php index c53a723a74c..e2af345c530 100644 --- a/lib/tests/behat/behat_navigation.php +++ b/lib/tests/behat/behat_navigation.php @@ -763,8 +763,6 @@ class behat_navigation extends behat_base { * @throws Exception with a meaningful error message if the specified page cannot be found. */ protected function resolve_core_page_instance_url(string $type, string $identifier): moodle_url { - global $DB; - $type = strtolower($type); switch ($type) { @@ -920,9 +918,8 @@ class behat_navigation extends behat_base { * @return void */ public function i_am_on_course_homepage($coursefullname) { - global $DB; - $course = $DB->get_record("course", array("fullname" => $coursefullname), 'id', MUST_EXIST); - $url = new moodle_url('/course/view.php', ['id' => $course->id]); + $courseid = $this->get_course_id($coursefullname); + $url = new moodle_url('/course/view.php', ['id' => $courseid]); $this->execute('behat_general::i_visit', [$url]); } @@ -944,10 +941,8 @@ class behat_navigation extends behat_base { * @param string $onoroff Whehter to switch editing on, or off. */ public function i_am_on_course_homepage_with_editing_mode_set_to(string $coursefullname, string $onoroff): void { - global $DB; - - $course = $DB->get_record("course", array("fullname" => $coursefullname), 'id', MUST_EXIST); - $url = new moodle_url('/course/view.php', ['id' => $course->id]); + $courseid = $this->get_course_id($coursefullname); + $url = new moodle_url('/course/view.php', ['id' => $courseid]); // Visit the course page. $this->execute('behat_general::i_visit', [$url]);