mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-17 14:35:29 +02:00
Code Issues Projects Releases Wiki Activity

MDL-70429 repository_contentbank: set default returntype

Browse Source 
Credits for Alexander Bias, for sharing the patch!

The content bank was designed for making easier to reuse content.
So "Link to the file" should be the default option when using the
contentbank repository, in order to let teachers modify their
content in the content bank and update automatically it everywhere
is used.
This commit is contained in:
Sara Arjona 2021-01-28 16:23:23 +01:00
parent fd840ab59c
commit d80613f9de
2 changed files with 11 additions and 2 deletions
repository/contentbank
lib.php
tests/behat
file_update.feature

9
repository/contentbank/lib.php

@ -107,6 +107,15 @@ class repository_contentbank extends repository {
return FILE_INTERNAL | FILE_REFERENCE;
}
/**
* Which return type should be selected by default.
*
* @return int
*/
public function default_returntype() {
return FILE_REFERENCE;
}
/**
* Is this repository accessing private data?
*

4
repository/contentbank/tests/behat/file_update.feature

@ -19,7 +19,7 @@ Feature: Updating a file in the content bank after using in a course
| page | PageName1 | PageDesc1 | 1 | C1 | H5Ptest | 1 | 1 |
And I log in as "admin"
Scenario: Referenced files updates alias as well
Scenario: Referenced files is the default option and updates alias as well
Given I am on "Course1" course homepage
And I follow "PageName1"
And I navigate to "Edit settings" in current page administration
@ -27,7 +27,6 @@ Feature: Updating a file in the content bank after using in a course
And I click on "Browse repositories..." "button" in the "Insert H5P" "dialogue"
And I select "Content bank" repository in file picker
And I click on "package.h5p" "file" in repository content area
And I click on "Link to the file" "radio"
And I click on "Select this file" "button"
And I click on "Insert H5P" "button" in the "Insert H5P" "dialogue"
And I wait until the page is ready
@ -69,6 +68,7 @@ Feature: Updating a file in the content bank after using in a course
And I click on "Browse repositories..." "button" in the "Insert H5P" "dialogue"
And I select "Content bank" repository in file picker
And I click on "package.h5p" "file" in repository content area
And I click on "Make a copy of the file" "radio"
And I click on "Select this file" "button"
And I click on "Insert H5P" "button" in the "Insert H5P" "dialogue"
And I wait until the page is ready