mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-73835 reportbuilder: ensure same report instance is exported.

Browse Source 
The exported system report should be re-created using all properties
of the persistent, as well as any passed parameters.
This commit is contained in:
Paul Holden 2022-02-10 12:22:55 +00:00
parent d24a4ab56f
commit d8158c4532
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
reportbuilder/download.php
View File

@ -42,18 +42,20 @@ $PAGE->set_context($context);
$PAGE->set_url(new moodle_url('/reportbuilder/download.php'));
if ($reportpersistent->get('type') === \core_reportbuilder\local\report\base::TYPE_SYSTEM_REPORT) {
$systemreport = system_report_factory::create($reportpersistent->get('source'), $context);
$parameters = (array) json_decode($parameters);
// Re-create the exact report that is being downloaded.
$systemreport = system_report_factory::create($reportpersistent->get('source'), $context, $reportpersistent->get('component'),
$reportpersistent->get('area'), $reportpersistent->get('itemid'), $parameters);
if (!$systemreport->can_be_downloaded()) {
throw new \core_reportbuilder\report_access_exception();
}
// Combine original report parameters with 'download' parameter.
$reportparameters = ['download' => $download];
if ($parameters) {
$reportparameters = array_merge($reportparameters, (array) json_decode($parameters));
}
$parameters['download'] = $download;
$outputreport = new \core_reportbuilder\output\system_report($reportpersistent, $systemreport, $reportparameters);
$outputreport = new \core_reportbuilder\output\system_report($reportpersistent, $systemreport, $parameters);
echo $PAGE->get_renderer('core_reportbuilder')->render($outputreport);
} else {
permission::require_can_view_report($reportpersistent);