MDL-45096 block_navigation: Check for existence of the siteadminbranch before modifying it

Prevents JS errors in some themes when admin block is hidden
This commit is contained in:
Steve Clay 2014-04-14 18:20:08 -04:00 committed by Andrew Nicols
parent d55806ce05
commit d8edfff658
4 changed files with 20 additions and 14 deletions

View File

@ -276,10 +276,12 @@ TREE.prototype = {
M.block_navigation.expandablebranchcount++;
this.branches[siteadminbranch.get('id')] = siteadminbranch;
// Remove link on site admin with JS to keep old UI.
var siteadminlinknode = siteadminbranch.node.get('childNodes').item(0);
if (siteadminlinknode) {
var siteadminnode = Y.Node.create('<span tabindex="0">'+siteadminlinknode.get('innerHTML')+'</span>');
siteadminbranch.node.replaceChild(siteadminnode, siteadminlinknode);
if (siteadminbranch.node) {
var siteadminlinknode = siteadminbranch.node.get('childNodes').item(0);
if (siteadminlinknode) {
var siteadminnode = Y.Node.create('<span tabindex="0">'+siteadminlinknode.get('innerHTML')+'</span>');
siteadminbranch.node.replaceChild(siteadminnode, siteadminlinknode);
}
}
}
if (M.block_navigation.expandablebranchcount > 0) {

View File

@ -275,10 +275,12 @@ TREE.prototype = {
M.block_navigation.expandablebranchcount++;
this.branches[siteadminbranch.get('id')] = siteadminbranch;
// Remove link on site admin with JS to keep old UI.
var siteadminlinknode = siteadminbranch.node.get('childNodes').item(0);
if (siteadminlinknode) {
var siteadminnode = Y.Node.create('<span tabindex="0">'+siteadminlinknode.get('innerHTML')+'</span>');
siteadminbranch.node.replaceChild(siteadminnode, siteadminlinknode);
if (siteadminbranch.node) {
var siteadminlinknode = siteadminbranch.node.get('childNodes').item(0);
if (siteadminlinknode) {
var siteadminnode = Y.Node.create('<span tabindex="0">'+siteadminlinknode.get('innerHTML')+'</span>');
siteadminbranch.node.replaceChild(siteadminnode, siteadminlinknode);
}
}
}
if (M.block_navigation.expandablebranchcount > 0) {

View File

@ -274,10 +274,12 @@ TREE.prototype = {
M.block_navigation.expandablebranchcount++;
this.branches[siteadminbranch.get('id')] = siteadminbranch;
// Remove link on site admin with JS to keep old UI.
var siteadminlinknode = siteadminbranch.node.get('childNodes').item(0);
if (siteadminlinknode) {
var siteadminnode = Y.Node.create('<span tabindex="0">'+siteadminlinknode.get('innerHTML')+'</span>');
siteadminbranch.node.replaceChild(siteadminnode, siteadminlinknode);
if (siteadminbranch.node) {
var siteadminlinknode = siteadminbranch.node.get('childNodes').item(0);
if (siteadminlinknode) {
var siteadminnode = Y.Node.create('<span tabindex="0">'+siteadminlinknode.get('innerHTML')+'</span>');
siteadminbranch.node.replaceChild(siteadminnode, siteadminlinknode);
}
}
}
if (M.block_navigation.expandablebranchcount > 0) {