mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-05-04 07:08:51 +02:00
Code Issues Projects Releases Wiki Activity

MDL-72006 navigation: Reduce max secondary nav items

Browse Source 
- Part of: MDL-69588
This commit is contained in:
Mathew May 2021-06-24 13:57:48 +08:00
parent d677a3b690
commit d9016d2fa7
2 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/classes/navigation/views/secondary.php
View File

@ -34,7 +34,7 @@ class secondary extends view {
public $headertitle;
/** @var int The maximum limit of navigation nodes displayed in the secondary navigation */
const MAX_DISPLAYED_NAV_NODES = 6;
const MAX_DISPLAYED_NAV_NODES = 5;
/**
* Defines the default structure for the secondary nav in a course context.

16
lib/tests/navigation/views/secondary_test.php
View File

@ -106,7 +106,7 @@ class secondary_test extends \advanced_testcase {
$assign = $this->getDataGenerator()->create_module('assign', ['course' => $pagecourse->id]);
$cm = get_coursemodule_from_id('assign', $assign->cmid);
$contextrecord = \context_module::instance($cm->id);
$pageurl = new \moodle_url('/mod/assign/view.php', ['id' => $cm->instance]);
$pageurl = new \moodle_url('/mod/assign/view.php', ['id' => $cm->id]);
$PAGE->set_cm($cm);
break;
case 'system':
@ -180,7 +180,7 @@ class secondary_test extends \advanced_testcase {
*/
public function test_force_nodes_into_more_menu_provider(): array {
return [
'The total number of navigation nodes exceeds the max display limit (6); ' .
'The total number of navigation nodes exceeds the max display limit (5); ' .
'navnode2 and navnode4 are forced into "more" menu by default.' =>
[
[
@ -201,10 +201,11 @@ class secondary_test extends \advanced_testcase {
[
'navnode2',
'navnode4',
'navnode8',
'navnode9',
],
],
'The total number of navigation nodes does not exceed the max display limit (6); ' .
'The total number of navigation nodes does not exceed the max display limit (5); ' .
'navnode2 and navnode4 are forced into "more" menu by default.' =>
[
[
@ -223,7 +224,7 @@ class secondary_test extends \advanced_testcase {
'navnode4',
],
],
'The total number of navigation nodes exceeds the max display limit (6); ' .
'The total number of navigation nodes exceeds the max display limit (5); ' .
'no forced navigation nodes into "more" menu by default.' =>
[
[
@ -238,11 +239,12 @@ class secondary_test extends \advanced_testcase {
],
[],
[
'navnode6',
'navnode7',
'navnode8',
],
],
'The total number of navigation nodes does not exceed the max display limit (6); ' .
'The total number of navigation nodes does not exceed the max display limit (5); ' .
'no forced navigation nodes into "more" menu by default.' =>
[
[
@ -254,7 +256,9 @@ class secondary_test extends \advanced_testcase {
[ 'text' => 'Navigation node 6', 'key' => 'navnode6'],
],
[],
[],
[
'navnode6',
],
],
];
}