From d91cbe1e62e4862afd5d1fb433d0a46011e5c6fd Mon Sep 17 00:00:00 2001
From: Cameron Ball <cameron@moodle.com>
Date: Mon, 28 Nov 2016 15:23:02 +0800
Subject: [PATCH] MDL-57177 theme_boost: Use regular ! for advanced form fields

Previously we used U+2757 on advanced form fields, which was problematic
as it's part of emoji and displays differently on different platforms.
This is a problem since we explicitly style it to be blue, but, for
example on OS X it's red (since it gets replaced with their emoji).
---
 theme/boost/scss/moodle/core.scss                             | 4 ++++
 theme/boost/templates/core_form/element-advcheckbox.mustache  | 2 +-
 theme/boost/templates/core_form/element-checkbox.mustache     | 2 +-
 theme/boost/templates/core_form/element-radio.mustache        | 2 +-
 .../templates/core_form/element-template-inline.mustache      | 2 +-
 theme/boost/templates/core_form/element-template.mustache     | 2 +-
 6 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/theme/boost/scss/moodle/core.scss b/theme/boost/scss/moodle/core.scss
index a346fa92f6e..a1ffad70f7e 100644
--- a/theme/boost/scss/moodle/core.scss
+++ b/theme/boost/scss/moodle/core.scss
@@ -121,6 +121,10 @@ a.dimmed_text:visited,
     @extend .text-info;
 }
 
+.fitem.advanced .text-info {
+    font-weight: bold;
+}
+
 .reportlink {
     text-align: right;
 }
diff --git a/theme/boost/templates/core_form/element-advcheckbox.mustache b/theme/boost/templates/core_form/element-advcheckbox.mustache
index 8ceb89a6e5d..a6cb35ce287 100644
--- a/theme/boost/templates/core_form/element-advcheckbox.mustache
+++ b/theme/boost/templates/core_form/element-advcheckbox.mustache
@@ -37,7 +37,7 @@
             {{/text}}
         </label>
         <span class="text-nowrap">
-            {{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">❗</abbr>{{/advanced}}
+            {{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">!</abbr>{{/advanced}}
             {{{helpbutton}}}
         </span>
         <div class="form-control-feedback" id="id_error_{{element.name}}" {{^error}} style="display: none;"{{/error}}>
diff --git a/theme/boost/templates/core_form/element-checkbox.mustache b/theme/boost/templates/core_form/element-checkbox.mustache
index 856c4d6152f..3a63cc43a2b 100644
--- a/theme/boost/templates/core_form/element-checkbox.mustache
+++ b/theme/boost/templates/core_form/element-checkbox.mustache
@@ -37,7 +37,7 @@
             {{/text}}
         </label>
         <span class="text-nowrap">
-            {{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">❗</abbr>{{/advanced}}
+            {{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">!</abbr>{{/advanced}}
             {{{helpbutton}}}
         </span>
         <div class="form-control-feedback" id="id_error_{{element.name}}" {{^error}} style="display: none;"{{/error}}>
diff --git a/theme/boost/templates/core_form/element-radio.mustache b/theme/boost/templates/core_form/element-radio.mustache
index c130b725d60..eecaa7d8c11 100644
--- a/theme/boost/templates/core_form/element-radio.mustache
+++ b/theme/boost/templates/core_form/element-radio.mustache
@@ -38,7 +38,7 @@
         </label>
         <span class="text-nowrap">
             {{#required}}<abbr class="initialism text-danger" title="{{#str}}required{{/str}}">✲</abbr>{{/required}}
-            {{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">❗</abbr>{{/advanced}}
+            {{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">!</abbr>{{/advanced}}
             {{{helpbutton}}}
         </span>
         <div class="form-control-feedback" id="id_error_{{element.name}}" {{^error}} style="display: none;"{{/error}}>
diff --git a/theme/boost/templates/core_form/element-template-inline.mustache b/theme/boost/templates/core_form/element-template-inline.mustache
index 5bcff0a16ff..851f92b2ce1 100644
--- a/theme/boost/templates/core_form/element-template-inline.mustache
+++ b/theme/boost/templates/core_form/element-template-inline.mustache
@@ -2,7 +2,7 @@
     <label class="col-form-label {{#element.hiddenlabel}}sr-only{{/element.hiddenlabel}}" for="{{element.id}}">
         {{{label}}} {{{helpbutton}}}
         {{#required}}<abbr class="initialism text-danger" title="{{#str}}required{{/str}}">✲</abbr>{{/required}}
-        {{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">❗</abbr>{{/advanced}}
+        {{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">!</abbr>{{/advanced}}
     </label>
     <span data-fieldtype="{{element.type}}">
         {{$ element }}
diff --git a/theme/boost/templates/core_form/element-template.mustache b/theme/boost/templates/core_form/element-template.mustache
index 4d7f82fa7e3..1af0c25fd93 100644
--- a/theme/boost/templates/core_form/element-template.mustache
+++ b/theme/boost/templates/core_form/element-template.mustache
@@ -2,7 +2,7 @@
     <div class="col-md-3">
         <span class="pull-xs-right text-nowrap">
             {{#required}}<abbr class="initialism text-danger" title="{{#str}}required{{/str}}">✲</abbr>{{/required}}
-            {{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">❗</abbr>{{/advanced}}
+            {{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">!</abbr>{{/advanced}}
             {{{helpbutton}}}
         </span>
         {{^element.staticlabel}}