From d9ae9e51cd6d2a6a38c10b2aecfb81cc20af36bd Mon Sep 17 00:00:00 2001 From: Andrew Nicols Date: Tue, 10 Jan 2023 11:19:02 +0800 Subject: [PATCH] MDL-76811 mod_data: Remove duplicate tests --- mod/data/tests/generator_test.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/mod/data/tests/generator_test.php b/mod/data/tests/generator_test.php index 516e15cb91b..eed49e5aec1 100644 --- a/mod/data/tests/generator_test.php +++ b/mod/data/tests/generator_test.php @@ -171,13 +171,10 @@ class generator_test extends \advanced_testcase { $record->type = $fieldtype; $record->required = 1; - ${$fieldname} = $this->getDataGenerator()->get_plugin_generator('mod_data')->create_field($record, $data); - $this->assertInstanceOf('data_field_' . $fieldtype, ${$fieldname}); + $this->getDataGenerator()->get_plugin_generator('mod_data')->create_field($record, $data); $count++; } - $this->assertEquals(count($fieldtypes), $DB->count_records('data_fields', ['dataid' => $data->id])); - $fields = $DB->get_records('data_fields', ['dataid' => $data->id], 'id'); $contents = [];