diff --git a/mod/h5pactivity/db/upgrade.php b/mod/h5pactivity/db/upgrade.php index c60863cb07b..85bcc909cc5 100644 --- a/mod/h5pactivity/db/upgrade.php +++ b/mod/h5pactivity/db/upgrade.php @@ -249,5 +249,20 @@ function xmldb_h5pactivity_upgrade($oldversion) { // Automatically generated Moodle v4.1.0 release upgrade line. // Put any upgrade step following this. + if ($oldversion < 2022112801) { + + // Remove any orphaned attempt/result records (pointing to non-existing activities). + $DB->delete_records_select('h5pactivity_attempts', 'NOT EXISTS ( + SELECT 1 FROM {h5pactivity} h5p WHERE h5p.id = {h5pactivity_attempts}.h5pactivityid + )'); + + $DB->delete_records_select('h5pactivity_attempts_results', 'NOT EXISTS ( + SELECT 1 FROM {h5pactivity_attempts} attempt WHERE attempt.id = {h5pactivity_attempts_results}.attemptid + )'); + + // H5pactivity savepoint reached. + upgrade_mod_savepoint(true, 2022112801, 'h5pactivity'); + } + return true; } diff --git a/mod/h5pactivity/lib.php b/mod/h5pactivity/lib.php index f35965fade5..91522009e4a 100644 --- a/mod/h5pactivity/lib.php +++ b/mod/h5pactivity/lib.php @@ -145,6 +145,13 @@ function h5pactivity_delete_instance(int $id): bool { return false; } + // Remove activity record, and all associated attempt data. + $attemptids = $DB->get_fieldset_select('h5pactivity_attempts', 'id', 'h5pactivityid = ?', [$id]); + if ($attemptids) { + $DB->delete_records_list('h5pactivity_attempts_results', 'attemptid', $attemptids); + $DB->delete_records_list('h5pactivity_attempts', 'id', $attemptids); + } + $DB->delete_records('h5pactivity', ['id' => $id]); h5pactivity_grade_item_delete($activity); diff --git a/mod/h5pactivity/version.php b/mod/h5pactivity/version.php index 369423bfbb2..91ff5c6d535 100644 --- a/mod/h5pactivity/version.php +++ b/mod/h5pactivity/version.php @@ -25,5 +25,5 @@ defined('MOODLE_INTERNAL') || die(); $plugin->component = 'mod_h5pactivity'; -$plugin->version = 2022112800; +$plugin->version = 2022112801; $plugin->requires = 2022111800;