From df496e57d6f941f38fd57255e2b49959a0608f95 Mon Sep 17 00:00:00 2001
From: Jun Pataleta <jun@moodle.com>
Date: Sat, 6 May 2023 00:03:27 +0800
Subject: [PATCH] MDL-78125 qtype_multianswer: Convert popover trigger to link

According to Boostrap Popovers documentation for popovers triggered
on focus:
"For proper cross-browser and cross-platform behavior, you must use the
<a> tag, not the <button> tag, and you also must include a tabindex
attribute."
---
 question/type/multianswer/renderer.php | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/question/type/multianswer/renderer.php b/question/type/multianswer/renderer.php
index ea71f60d3aa..528e7aacda4 100644
--- a/question/type/multianswer/renderer.php
+++ b/question/type/multianswer/renderer.php
@@ -212,8 +212,9 @@ abstract class qtype_multianswer_subq_renderer_base extends qtype_renderer {
             return '';
         }
 
-        return html_writer::tag('button', $icon, [
-            'type' => 'button',
+        return html_writer::link('#', $icon, [
+            'role' => 'button',
+            'tabindex' => 0,
             'class' => 'btn btn-link p-0',
             'data-toggle' => 'popover',
             'data-container' => 'body',