mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-22 00:20:37 +01:00
Code Issues Projects Releases Wiki Activity

MDL-70844 core: Pass anchors instead of URL for siteadmin tabs.

Browse Source
This commit is contained in:
Peter Dias 2021-02-16 09:22:54 +08:00
parent 4c26696e7e
commit dbda380b4e
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/classes/navigation/views/secondary.php
View File

@ -192,10 +192,28 @@ class secondary extends view {
protected function load_admin_navigation(): void {
$settingsnav = $this->page->settingsnav;
$node = $settingsnav->find('root', self::TYPE_SITE_ADMIN);
// We need to know if we are on the main site admin search page. Here the navigation between tabs are done via
// anchors and page reload doesn't happen. On every nested admin settings page, the secondary nav needs to
// exist as links with anchors appended in order to redirect back to the admin search page and the corresponding
// tab.
$isadminsearchpage = $this->page->pagetype === 'admin-search';
if ($node) {
$siteadminnode = $this->add($node->text, "#link$node->key", null, null, 'siteadminnode');
if ($isadminsearchpage) {
$siteadminnode->action = false;
$siteadminnode->tab = "#link$node->key";
} else {
$siteadminnode->action = new \moodle_url("/admin/search.php", [], "link$node->key");
}
foreach ($node->children as $child) {
if ($child->display && !$child->is_short_branch()) {
// Mimic the current boost behaviour and pass down anchors for the tabs.
if ($isadminsearchpage) {
$child->action = false;
$child->tab = "#link$child->key";
} else {
$child->action = new \moodle_url("/admin/search.php", [], "link$child->key");
}
$this->add_node($child);
} else {
$siteadminnode->add_node($child);