mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 16:32:18 +02:00
Code Issues Projects Releases Wiki Activity

MDL-53778 quiz: ensure completion deps are fulfilled by generator uses

Browse Source 
There are some mod_quiz generator issues where the new chain
of dependencies between completion settings was not being observed.

This patch just ensures that the now 3 chained settings are
enabled together (or new quiz options logic will proceed to
disable them).
This commit is contained in:
Eloy Lafuente (stronk7) 2019-06-27 00:01:43 +02:00
parent 6f5990024c
commit dcb8f5fefb
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mod/quiz/tests/lib_test.php
View File

@ -166,6 +166,7 @@ class mod_quiz_lib_testcase extends advanced_testcase {
'questionsperpage' => 0,
'sumgrades' => 1,
'completion' => COMPLETION_TRACKING_AUTOMATIC,
'completionusegrade' => 1,
'completionpass' => 1);
$quiz = $quizgenerator->create_instance($data);
$cm = get_coursemodule_from_id('quiz', $quiz->cmid);
@ -880,14 +881,14 @@ class mod_quiz_lib_testcase extends advanced_testcase {
$quiz1 = $this->getDataGenerator()->create_module('quiz', [
'course' => $course->id,
'completion' => 2,
'completionusegrade' => 1,
'completionattemptsexhausted' => 1,
'completionpass' => 1
]);
$quiz2 = $this->getDataGenerator()->create_module('quiz', [
'course' => $course->id,
'completion' => 2,
'completionattemptsexhausted' => 0,
'completionpass' => 0
'completionusegrade' => 0
]);
$cm1 = cm_info::create(get_coursemodule_from_instance('quiz', $quiz1->id));
$cm2 = cm_info::create(get_coursemodule_from_instance('quiz', $quiz2->id));