From e4ba5d276d55c0892faa449eb29c153130a019c8 Mon Sep 17 00:00:00 2001 From: Paul Holden Date: Tue, 8 Aug 2023 17:20:45 +0100 Subject: [PATCH] MDL-78533 grade: relax param type of itemname in external structures. Ensure it conforms to the same format as allowed for course modules. --- grade/report/user/classes/external/user.php | 2 +- grade/upgrade.txt | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/grade/report/user/classes/external/user.php b/grade/report/user/classes/external/user.php index 650a0b18794..2a843347275 100644 --- a/grade/report/user/classes/external/user.php +++ b/grade/report/user/classes/external/user.php @@ -508,7 +508,7 @@ class user extends external_api { new external_single_structure( [ 'id' => new external_value(PARAM_INT, 'Grade item id'), - 'itemname' => new external_value(PARAM_TEXT, 'Grade item name'), + 'itemname' => new external_value(PARAM_CLEANHTML, 'Grade item name'), 'itemtype' => new external_value(PARAM_ALPHA, 'Grade item type'), 'itemmodule' => new external_value(PARAM_PLUGIN, 'Grade item module'), 'iteminstance' => new external_value(PARAM_INT, 'Grade item instance'), diff --git a/grade/upgrade.txt b/grade/upgrade.txt index c51175a4936..49e4603f227 100644 --- a/grade/upgrade.txt +++ b/grade/upgrade.txt @@ -1,6 +1,10 @@ This file describes API changes in /grade/* ; Information provided here is intended especially for developers. +=== 4.1.6 === +* The grade `itemname` property contained in the return structure of the following external methods is now PARAM_CLEANHTML: + - `gradereport_user_get_grade_items` + === 4.1 === * The $importactiveurl parameter in the constructor of the core_grades\output\import_action_bar class has been deprecated and is not used anymore. * The $exportactiveurl parameter in the constructor of the core_grades\output\export_action_bar class has been deprecated and is not used anymore.