mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-07-25 00:02:18 +02:00
Code Issues Projects Releases Wiki Activity

MDL-35754 libraries: openpopup() does not fail when window name is not set

Browse Source
This commit is contained in:
Frederic Massart
2012-10-03 09:49:01 +08:00
parent 5d6285c220
commit df435dda49
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/javascript-static.js
View File

@@ -1212,9 +1212,12 @@ function openpopup(event, args) {
}
}
// Cleans window name because IE does not support funky ones.
// Make sure the name argument is set and valid.
var nameregex = /[^a-z0-9_]/i;
if (args.name.match(nameregex)) {
if (typeof args.name !== 'string') {
args.name = '_blank';
} else if (args.name.match(nameregex)) {
// Cleans window name because IE does not support funky ones.
args.name = args.name.replace(nameregex, '_');
if (M.cfg.developerdebug) {
alert('DEVELOPER NOTICE: Invalid \'name\' passed to openpopup()');