mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-14 13:02:07 +02:00
Code Issues Projects Releases Wiki Activity

MDL-77533 customfield: fix exception thrown during handler retrieval.

Browse Source
This commit is contained in:
Paul Holden 2023-03-06 09:05:52 +00:00
parent 556208417d
commit e084865f19
No known key found for this signature in database
GPG Key ID: A81A96D6045F6164
2 changed files with 52 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
customfield/classes/handler.php
View File

@ -117,7 +117,7 @@ abstract class handler {
return $classname::create($itemid);
}
$a = ['component' => s($component), 'area' => s($area)];
throw new \moodle_exception('unknownhandler', 'core_customfield', (object)$a);
throw new \moodle_exception('unknownhandler', 'core_customfield', '', $a);
}
/**

51
customfield/tests/handler_test.php Normal file
View File

@ -0,0 +1,51 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
declare(strict_types=1);
namespace core_customfield;
use advanced_testcase;
use core_course\customfield\course_handler;
use moodle_exception;
/**
* Unit tests for the abstract custom fields handler
*
* @package core_customfield
* @covers \core_customfield\handler
* @copyright 2023 Paul Holden <paulh@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class handler_test extends advanced_testcase {
/**
* Test retrieving handler for given component/area
*/
public function test_get_handler(): void {
$handler = handler::get_handler('core_course', 'course');
$this->assertInstanceOf(course_handler::class, $handler);
}
/**
* Test retrieving handler for invalid component/area
*/
public function test_get_handler_invalid(): void {
$this->expectException(moodle_exception::class);
$this->expectExceptionMessage('Unable to find handler for custom fields for component core_blimey and area test');
handler::get_handler('core_blimey', 'test');
}
}