mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-27 03:14:20 +02:00
Code Issues Projects Releases Wiki Activity

random question history MDL-20951: Two minor bugs in the fix for MDL-20776.

Browse Source 
Thanks to Oleg Sychev for noticing these problems.
This commit is contained in:
Tim Hunt 2009-11-24 11:49:21 +00:00
parent 55f5b2e8b8
commit e14de5aa1c
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
question/type/questiontype.php
View File

@ -1088,8 +1088,10 @@ class default_questiontype {
$params = array('aid' => $state->attempt);
if (isset($question->randomquestionid)) {
$params['qid'] = $question->randomquestionid;
$randomprefix = 'random' . $question->id . '-';
} else {
$params['qid'] = $question->id;
$randomprefix = '';
}
if ($options->history == 'all') {
$eventtest = 'event > 0';
@ -1098,7 +1100,7 @@ class default_questiontype {
}
$states = $DB->get_records_select('question_states',
'attempt = :aid AND question = :qid AND ' . $eventtest, $params, 'seq_number ASC');
if (empty($states)) {
if (count($states) <= 1) {
return '';
}
@ -1117,6 +1119,9 @@ class default_questiontype {
}
foreach ($states as $st) {
if ($randomprefix && strpos($st->answer, $randomprefix) === 0) {
$st->answer = substr($st->answer, strlen($randomprefix));
}
$st->responses[''] = $st->answer;
$this->restore_session_and_responses($question, $st);