mirror of
https://github.com/moodle/moodle.git
synced 2025-03-14 20:50:21 +01:00
MDL-81333 core_communication: Coding style fixups
- Remove superflous coverage information - Use language string for group room name format
This commit is contained in:
parent
2ec967e12b
commit
e168c1d089
@ -559,6 +559,9 @@ class helper {
|
||||
string $baseroomname,
|
||||
string $groupname
|
||||
): string {
|
||||
return "{$groupname} ({$baseroomname})";
|
||||
return get_string('communicationgrouproomnameformat', 'core_communication', [
|
||||
'groupname' => $groupname,
|
||||
'baseroomname' => $baseroomname,
|
||||
]);
|
||||
}
|
||||
}
|
||||
|
@ -223,8 +223,6 @@ class helper_test extends \advanced_testcase {
|
||||
|
||||
/**
|
||||
* Test format_group_room_name.
|
||||
*
|
||||
* @covers ::format_group_room_name
|
||||
*/
|
||||
public function test_format_group_room_name(): void {
|
||||
$baseroomname = 'Course A';
|
||||
|
@ -29,6 +29,7 @@ $string['communicationroomname'] = 'Room name';
|
||||
$string['communicationroomnameinfo'] = 'If the field is left blank, the course name is used as the room name.';
|
||||
$string['communicationroompending'] = 'Your {$a} room will be ready soon.';
|
||||
$string['communicationroomready'] = 'Your {$a} room is ready.';
|
||||
$string['communicationgrouproomnameformat'] = '{$a->groupname} ({$a->baseroomname})';
|
||||
$string['managecommunicationproviders'] = 'Manage communication providers';
|
||||
$string['nocommunicationinstance'] = 'No communication instance found.';
|
||||
$string['nocommunicationprovider'] = 'No communication provider found.';
|
||||
|
Loading…
x
Reference in New Issue
Block a user