mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-19 07:25:30 +02:00
Code Issues Projects Releases Wiki Activity

MDL-77544 enrol_database: Make sure column mapping config match case

Browse Source 
Some databases may have case-sensitive collation that will cause the
generated SQL query in `\enrol_database_plugin::sync_courses()` to fail
when using values for the plugin settings `newcoursestartdate` and
`newcourseenddate` with a different case compared to the columns
in the actual external database table.

For the sake of testing sync with start and end dates, let's make sure
that the config values match the case of the enrol test table's columns
for the start and end dates.
This commit is contained in:
Jun Pataleta 2024-08-20 17:58:36 +08:00 committed by Huong Nguyen
parent 6e3bb56ef6
commit e19837463b
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
enrol/database/tests/sync_test.php
View File

@ -860,9 +860,8 @@ class sync_test extends \advanced_testcase {
$DB->insert_record('enrol_database_test_courses', $course8);
$DB->insert_record('enrol_database_test_courses', $course9);
// Mess with case as we need to check that fields are lower cased.
$plugin->set_config('newcoursestartdate', 'StartDaTE');
$plugin->set_config('newcourseenddate', 'ENDdATE');
$plugin->set_config('newcoursestartdate', 'startdate');
$plugin->set_config('newcourseenddate', 'enddate');
$plugin->sync_courses($trace);