mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-53988 mod_lti: Remove popup for duplicate url

Browse Source 
If creating a proxy fails, we will show an error using the
notification API. So we can remove the notification.exception call.
But modify the docs for ToolProxy.create so that future developers
will know they need to handle failures themselves.
This commit is contained in:
John Okely 2016-05-20 12:05:55 +08:00
parent 2be707cb5e
commit e1e1aad183
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mod/lti/amd/build/tool_proxy.min.js vendored
View File

@ -1 +1 @@
define(["core/ajax","core/notification"],function(a,b){return{query:function(c){var d={methodname:"mod_lti_get_tool_proxies",args:c||{}},e=a.call([d])[0];return e.fail(b.exception),e},"delete":function(c){var d={methodname:"mod_lti_delete_tool_proxy",args:{id:c}},e=a.call([d])[0];return e.fail(b.exception),e},create:function(c){var d={methodname:"mod_lti_create_tool_proxy",args:c},e=a.call([d])[0];return e.fail(b.exception),e}}});
define(["core/ajax","core/notification"],function(a,b){return{query:function(c){var d={methodname:"mod_lti_get_tool_proxies",args:c||{}},e=a.call([d])[0];return e.fail(b.exception),e},"delete":function(c){var d={methodname:"mod_lti_delete_tool_proxy",args:{id:c}},e=a.call([d])[0];return e.fail(b.exception),e},create:function(b){var c={methodname:"mod_lti_create_tool_proxy",args:b},d=a.call([c])[0];return d}}});

4
mod/lti/amd/src/tool_proxy.js
View File

@ -75,6 +75,8 @@ define(['core/ajax', 'core/notification'], function(ajax, notification) {
/**
* Create a tool proxy in Moodle.
*
* The promise will fail if the proxy cannot be created, so you must handle the fail result.
*
* See mod/lti/classes/external.php create_tool_proxy_parameters
*
* @method create
@ -90,8 +92,6 @@ define(['core/ajax', 'core/notification'], function(ajax, notification) {
var promise = ajax.call([request])[0];
promise.fail(notification.exception);
return promise;
}
};