mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-09 18:30:03 +01:00
Code Issues Projects Releases Wiki Activity

MDL-43306 restore: fix grade item sortorder restoration

Browse Source 
Previously, restore was blindly inserting the old sort order into the
database, causing duplicate sortorders which lead to unpredicatble
sorting results.

Now we will use the api function to add it after the original sortorder,
this means if a duplicate exists in the original location, this item
will appear after it.
This commit is contained in:
Dan Poltawski 2013-12-10 11:54:13 +08:00
parent c36a2401ab
commit e238b2cb92
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
backup/moodle2/restore_stepslib.php
View File

@ -2782,9 +2782,9 @@ class restore_activity_grades_structure_step extends restore_structure_step {
$gradeitem = new grade_item($data, false);
$gradeitem->insert('restore');
//sortorder is automatically assigned when inserting. Re-instate the previous sortorder
$gradeitem->sortorder = $data->sortorder;
$gradeitem->update('restore');
// Reinstate the grade item close to its original sortorder, if something already exists
// in the original sortorer then it will be first.
$gradeitem->move_after_sortorder($data->sortorder);
// Set mapping, saving the original category id into parentitemid
// gradebook restore (final task) will need it to reorganise items