mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-14 12:40:01 +01:00
Code Issues Projects Releases Wiki Activity

MDL-80844 phpunit: Only some tests can use the debugging sink

Browse Source 
The only tests that have COMPLETE* support for the debugging sink
are the advanced_testcase and the database_driver ones (store and
report). So we must ensure that the rest of tests don't use the
debugging sink at all.

Right now we are using it for storing, but later there is not
reporting, so any debugging happening within non advanced tests
is not detected.

This commit just ensures that we stop making that storing for
non advanced/database_driver tests. Nothing more, nothing less.

* Note that we have had to add a few missing bits to the
database_driver testcase because it was not 100% complete. Now
it behaves 100% the same than the advanced_testcase one regarding
the debugging sink.
This commit is contained in:
Eloy Lafuente (stronk7) 2024-02-06 14:52:07 +01:00
parent 8a38a37f1f
commit e31db928b5
No known key found for this signature in database
GPG Key ID: 53487A05E6228820
2 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/phpunit/classes/database_driver_testcase.php
View File

@ -142,6 +142,13 @@ abstract class database_driver_testcase extends base_testcase {
try {
parent::runBare();
// Deal with any debugging messages.
$debugerror = phpunit_util::display_debugging_messages(true);
$this->resetDebugging();
if (!empty($debugerror)) {
trigger_error('Unexpected debugging() call detected.' . "\n" . $debugerror, E_USER_NOTICE);
}
} catch (Exception $ex) {
$e = $ex;
} catch (Throwable $ex) {

23
lib/phpunit/classes/util.php
View File

@ -672,8 +672,29 @@ class phpunit_util extends testing_util {
// we need normal debugging outside of tests to find problems in our phpunit integration.
$backtrace = debug_backtrace();
// Only for advanced_testcase, database_driver_testcase (and descendants). Others aren't
// able to manage the debugging sink, so any debugging has to be output normally and, hopefully,
// PHPUnit execution will catch that unexpected output properly.
$sinksupport = false;
foreach ($backtrace as $bt) {
if (isset($bt['object']) and is_object($bt['object'])
if (isset($bt['object']) && is_object($bt['object'])
&& (
$bt['object'] instanceof advanced_testcase ||
$bt['object'] instanceof database_driver_testcase)
) {
$sinksupport = true;
break;
}
}
if (!$sinksupport) {
return false;
}
// Verify that we are inside a PHPUnit test (little bit redundant, because
// we already have checked above that this is an advanced/database_driver
// testcase, but let's keep things double safe for now).
foreach ($backtrace as $bt) {
if (isset($bt['object']) && is_object($bt['object'])
&& $bt['object'] instanceof PHPUnit\Framework\TestCase) {
$debug = new stdClass();
$debug->message = $message;