mirror of
https://github.com/moodle/moodle.git
synced 2025-04-21 00:12:56 +02:00
MDL-11448 FirstClass Authentication does not hold settings and has cosmetic and info leakage issues, patch by Dan Trockman
This commit is contained in:
parent
1bc8aab1c5
commit
e5245c73a5
@ -88,7 +88,7 @@ class auth_plugin_fc extends auth_plugin_base {
|
||||
|
||||
$userinfo = array();
|
||||
|
||||
$fpp = new fcFPP($this->config->host, $this->config->port);
|
||||
$fpp = new fcFPP($this->config->host, $this->config->fppport);
|
||||
if ($fpp->open()) {
|
||||
if ($fpp->login($this->config->userid, $this->config->passwd)) {
|
||||
$userinfo['firstname'] = $fpp->getUserInfo($username,"1202");
|
||||
@ -121,7 +121,7 @@ class auth_plugin_fc extends auth_plugin_base {
|
||||
|
||||
$fcgroups = array();
|
||||
|
||||
$fpp = new fcFPP($this->config->host, $this->config->port);
|
||||
$fpp = new fcFPP($this->config->host, $this->config->fppport);
|
||||
if ($fpp->open()) {
|
||||
if ($fpp->login($this->config->userid, $this->config->passwd)) {
|
||||
$fcgroups = $fpp->getGroups($username);
|
||||
@ -224,7 +224,7 @@ class auth_plugin_fc extends auth_plugin_base {
|
||||
}
|
||||
|
||||
// save settings
|
||||
set_config('host', $config->user, 'auth/fc');
|
||||
set_config('host', $config->host, 'auth/fc');
|
||||
set_config('fppport', $config->fppport, 'auth/fc');
|
||||
set_config('userid', $config->userid, 'auth/fc');
|
||||
set_config('passwd', $config->passwd, 'auth/fc');
|
||||
|
@ -50,7 +50,7 @@ class fcFPP
|
||||
$conn = fsockopen($host, $port, $errno, $errstr, 5);
|
||||
if (!$conn)
|
||||
{
|
||||
print_error('auth_fcconnfail','auth', array($errno, $errstr));
|
||||
print_error('auth_fcconnfail','auth', '', array($errno, $errstr));
|
||||
return false;
|
||||
}
|
||||
|
||||
|
@ -123,7 +123,7 @@ $string['auth_fchost'] = 'The FirstClass server address. Use the IP number or DN
|
||||
$string['auth_fcpasswd'] = 'Password for the account above.';
|
||||
$string['auth_fctitle'] = 'FirstClass server';
|
||||
$string['auth_fcuserid'] = 'Userid for FirstClass account with privilege \'Subadministrator\' set.';
|
||||
$string['auth_fchost_key'] = 'Host:';
|
||||
$string['auth_fchost_key'] = 'Host';
|
||||
$string['auth_fcfppport_key'] = 'Port';
|
||||
$string['auth_fcuserid_key'] = 'User ID';
|
||||
$string['auth_fcpasswd_key'] = 'Password';
|
||||
|
Loading…
x
Reference in New Issue
Block a user