mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 22:08:20 +01:00
Code Issues Projects Releases Wiki Activity

MDL-11937 - save 100 database queries in the case of the admin bookmarks block

Browse Source 
without bookmarks on non-admin page

Merged from MOODLE_19_STABLE
This commit is contained in:
poltawski 2007-10-28 23:06:39 +00:00
parent a559f6306e
commit e6262fcd0d
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
blocks/admin_bookmarks/block_admin_bookmarks.php
View File

@ -31,9 +31,6 @@ class block_admin_bookmarks extends block_base {
global $CFG, $USER, $PAGE;
require_once($CFG->libdir.'/adminlib.php');
$adminroot = admin_get_root();
if ($this->content !== NULL) {
return $this->content;
}
@ -41,6 +38,10 @@ class block_admin_bookmarks extends block_base {
$this->content = new stdClass;
$this->content->text = '';
if (get_user_preferences('admin_bookmarks')) {
// this is expensive! Only require when bookmakrs exist..
require_once($CFG->libdir.'/adminlib.php');
$adminroot = admin_get_root();
$bookmarks = explode(',',get_user_preferences('admin_bookmarks'));
// hmm... just a liiitle (potentially) processor-intensive
// (recall that $adminroot->locate is a huge recursive call... and we're calling it repeatedly here