From c5d022aed6cad037830a2a5769fcf63c6c4b8786 Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Mon, 9 Sep 2024 17:00:29 +0800 Subject: [PATCH 1/2] MDL-83047 theme_boost: Apply background colour only on select layouts * Apply the styling of `background-color` for `.page-header-headings` only in the maintenance and secure layouts. --- theme/boost/scss/moodle/core.scss | 7 +++++-- theme/boost/style/moodle.css | 3 ++- theme/classic/style/moodle.css | 3 ++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/theme/boost/scss/moodle/core.scss b/theme/boost/scss/moodle/core.scss index 2f05ecaaf2f..5dd3612ea01 100644 --- a/theme/boost/scss/moodle/core.scss +++ b/theme/boost/scss/moodle/core.scss @@ -3086,8 +3086,11 @@ blockquote { border-left: 5px solid $gray-500; } -.page-header-headings { - background-color: $body-bg; +.pagelayout-maintenance, +.pagelayout-secure { + .page-header-headings { + background-color: $body-bg; + } } /* Prevent long strings exceeding page width */ diff --git a/theme/boost/style/moodle.css b/theme/boost/style/moodle.css index 3446ea52216..d68cbbcdcfd 100644 --- a/theme/boost/style/moodle.css +++ b/theme/boost/style/moodle.css @@ -26045,7 +26045,8 @@ blockquote { border-left: 5px solid #8f959e; } -.page-header-headings { +.pagelayout-maintenance .page-header-headings, +.pagelayout-secure .page-header-headings { background-color: #fff; } diff --git a/theme/classic/style/moodle.css b/theme/classic/style/moodle.css index 4ab448104a5..3d9134955e0 100644 --- a/theme/classic/style/moodle.css +++ b/theme/classic/style/moodle.css @@ -26045,7 +26045,8 @@ blockquote { border-left: 5px solid #8f959e; } -.page-header-headings { +.pagelayout-maintenance .page-header-headings, +.pagelayout-secure .page-header-headings { background-color: #fff; } From 40282c85ac081c9524984d40b086063c64f348c7 Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Tue, 10 Sep 2024 10:29:56 +0800 Subject: [PATCH 2/2] MDL-83047 theme_boost: Add upgrade note for theme plugins --- .upgradenotes/MDL-83047-2024091002230447.yml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 .upgradenotes/MDL-83047-2024091002230447.yml diff --git a/.upgradenotes/MDL-83047-2024091002230447.yml b/.upgradenotes/MDL-83047-2024091002230447.yml new file mode 100644 index 00000000000..840fedb94d3 --- /dev/null +++ b/.upgradenotes/MDL-83047-2024091002230447.yml @@ -0,0 +1,17 @@ +issueNumber: MDL-83047 +notes: + theme_boost: + - message: >+ + The `.page-header-headings` CSS class now has a background colour + applied to the maintenance and secure layouts. + + + You may need to override this class in your maintenance and secure + layouts if both of the following are true: + + * Your theme plugin inherits from `theme_boost` and uses this CSS class + + * Your theme plugin applies a different styling for the page header for + the maintenance and secure layouts. + + type: changed