mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-24 18:04:43 +02:00
Code Issues Projects Releases Wiki Activity

MDL-76052 webservice_xmlrpc: Annotate some wrong plugin uses

Browse Source 
It has been detected that there are various uses of the plugins
breaking the inter-communication principles, with core_webservice
implementing functionality plugin-dependent that should belong
to the plugins.

Because of that, https://tracker.moodle.org/browse/MDL-76078 has
been created and we have added some TODO/@todo comments in core
pointing to that issue, for further analysis and fixes there.
This commit is contained in:
Eloy Lafuente (stronk7) 2022-10-25 19:11:30 +02:00
parent df227f3819
commit e7d3e042fc
3 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
admin/webservice/documentation.php
View File

@ -36,6 +36,8 @@ foreach ($functions as $function) {
$functiondescs[$function->name] = external_api::external_function_info($function);
}
// TODO: MDL-76078 - Incorrect inter-communication, core cannot have plugin dependencies like this.
//display the documentation for all documented protocols,
//regardless if they are activated or not
$protocols = array();

6
webservice/renderer.php
View File

@ -497,6 +497,8 @@ EOF;
/**
* Create indented XML-RPC param description
*
* @todo MDL-76078 - Incorrect inter-communication, core cannot have plugin dependencies like this.
*
* @param external_description $paramdescription the description structure of the web service function parameters
* @param string $indentation Indentation in the generated HTML code; should contain only spaces.
* @return string the html to diplay
@ -575,6 +577,8 @@ EOF;
/**
* Return indented REST param description
*
* @todo MDL-76078 - Incorrect inter-communication, core cannot have plugin dependencies like this.
*
* @param external_description $paramdescription the description structure of the web service function parameters
* @param string $paramstring parameter
* @return string the html to diplay
@ -620,6 +624,8 @@ EOF;
/**
* Displays all the documentation
*
* @todo MDL-76078 - Incorrect inter-communication, core cannot have plugin dependencies like this.
*
* @param array $functions external_description of all the web service functions
* @param boolean $printableformat true if we want to display the documentation in a printable format
* @param array $activatedprotocol the currently enabled protocol

2
webservice/wsdoc.php
View File

@ -68,6 +68,8 @@ foreach ($functions as $function) {
$functiondescs[$function->name] = external_api::external_function_info($function);
}
// TODO: MDL-76078 - Incorrect inter-communication, core cannot have plugin dependencies like this.
// get activated protocol
$activatedprotocol = array();
$activatedprotocol['rest'] = webservice_protocol_is_enabled('rest');