diff --git a/mod/quiz/classes/event/question_manually_graded.php b/mod/quiz/classes/event/question_manually_graded.php new file mode 100644 index 00000000000..d6444dc922d --- /dev/null +++ b/mod/quiz/classes/event/question_manually_graded.php @@ -0,0 +1,109 @@ +. + +/** + * Question manually graded event class. + * + * @property-read array $other { + * Extra information about event. + * + * - int quizid: the id of the quiz. + * - int attemptid: the id of the attempt. + * - int slot: the question number in the attempt. + * } + * + * @package core + * @since Moodle 2.7 + * @copyright 2014 Mark Nelson + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ +namespace mod_quiz\event; + +defined('MOODLE_INTERNAL') || die(); + +class question_manually_graded extends \core\event\base { + + /** + * Init method. + */ + protected function init() { + $this->data['objecttable'] = 'question'; + $this->data['crud'] = 'c'; + $this->data['edulevel'] = self::LEVEL_TEACHING; + } + + /** + * Returns localised general event name. + * + * @return string + */ + public static function get_name() { + return get_string('eventquestionmanuallygraded', 'mod_quiz'); + } + + /** + * Returns description of what happened. + * + * @return string + */ + public function get_description() { + return 'A question with the id of ' . $this->objectid . ' was manually graded by a user with the id ' . $this->userid . + ' for the attempt with the id ' . $this->other['attemptid']; + } + + /** + * Returns relevant URL. + * + * @return \moodle_url + */ + public function get_url() { + return new \moodle_url('/mod/quiz/comment.php', array('attempt' => $this->other['attemptid'], + 'slot' => $this->other['slot'])); + } + + /** + * Return the legacy event log data. + * + * @return array + */ + protected function get_legacy_logdata() { + return array($this->courseid, 'quiz', 'manualgrade', 'comment.php?attempt=' . $this->other['attemptid'] . + '&slot=' . $this->other['slot'], $this->other['quizid'], $this->contextinstanceid); + } + + /** + * Custom validation. + * + * @throws \coding_exception + * @return void + */ + protected function validate_data() { + parent::validate_data(); + + if (!isset($this->other['quizid'])) { + throw new \coding_exception('The \'quizid\' must be set in other.'); + } + + if (!isset($this->other['attemptid'])) { + throw new \coding_exception('The \'attemptid\' must be set in other.'); + } + + if (!isset($this->other['slot'])) { + throw new \coding_exception('The \'slot\' must be set in other.'); + } + + } +} diff --git a/mod/quiz/comment.php b/mod/quiz/comment.php index 754b88dcee9..c1961ab2a8d 100644 --- a/mod/quiz/comment.php +++ b/mod/quiz/comment.php @@ -42,11 +42,6 @@ if (!$attemptobj->is_finished()) { require_login($attemptobj->get_course(), false, $attemptobj->get_cm()); $attemptobj->require_capability('mod/quiz:grade'); -// Log this action. -add_to_log($attemptobj->get_courseid(), 'quiz', 'manualgrade', 'comment.php?attempt=' . - $attemptobj->get_attemptid() . '&slot=' . $slot, - $attemptobj->get_quizid(), $attemptobj->get_cmid()); - // Print the page header. $PAGE->set_pagelayout('popup'); $PAGE->set_heading($attemptobj->get_course()->fullname); @@ -74,6 +69,21 @@ if (data_submitted() && confirm_sesskey()) { $transaction = $DB->start_delegated_transaction(); $attemptobj->process_submitted_actions(time()); $transaction->allow_commit(); + + // Log this action. + $params = array( + 'objectid' => $attemptobj->get_question_attempt($slot)->get_question()->id, + 'courseid' => $attemptobj->get_courseid(), + 'context' => context_module::instance($attemptobj->get_cmid()), + 'other' => array( + 'quizid' => $attemptobj->get_quizid(), + 'attemptid' => $attemptobj->get_attemptid(), + 'slot' => $slot + ) + ); + $event = \mod_quiz\event\question_manually_graded::create($params); + $event->trigger(); + echo $output->notification(get_string('changessaved'), 'notifysuccess'); close_window(2, true); die; diff --git a/mod/quiz/lang/en/quiz.php b/mod/quiz/lang/en/quiz.php index 001ae8c82f5..54966da9fd0 100644 --- a/mod/quiz/lang/en/quiz.php +++ b/mod/quiz/lang/en/quiz.php @@ -313,6 +313,7 @@ $string['eventattemptviewed'] = 'Quiz attempt viewed'; $string['eventeditpageviewed'] = 'Quiz edit page viewed'; $string['eventoverridedeleted'] = 'Quiz override deleted'; $string['eventoverrideupdated'] = 'Quiz override updated'; +$string['eventquestionmanuallygraded'] = 'Question manually graded'; $string['eventquizattemptabandoned'] = 'Quiz attempt abandoned'; $string['eventquizattempttimelimitexceeded'] = 'Quiz attempt time limit exceeded'; $string['eventquizattemptstarted'] = 'Quiz attempt started'; diff --git a/mod/quiz/tests/events_test.php b/mod/quiz/tests/events_test.php index c1138e2ae27..41fca91393e 100644 --- a/mod/quiz/tests/events_test.php +++ b/mod/quiz/tests/events_test.php @@ -610,4 +610,40 @@ class mod_quiz_events_testcase extends advanced_testcase { $this->assertEventLegacyLogData($expected, $event); $this->assertEventContextNotUsed($event); } + + /** + * Test the question manually graded event. + * + * There is no external API for manually grading a question, so the unit test will simply + * create and trigger the event and ensure the event data is returned as expected. + */ + public function test_question_manually_graded() { + list($quizobj, $quba, $attempt) = $this->prepare_quiz_data(); + + $params = array( + 'objectid' => 1, + 'courseid' => $quizobj->get_courseid(), + 'context' => context_module::instance($quizobj->get_cmid()), + 'other' => array( + 'quizid' => $quizobj->get_quizid(), + 'attemptid' => 2, + 'slot' => 3 + ) + ); + $event = \mod_quiz\event\question_manually_graded::create($params); + + // Trigger and capture the event. + $sink = $this->redirectEvents(); + $event->trigger(); + $events = $sink->get_events(); + $event = reset($events); + + // Check that the event data is valid. + $this->assertInstanceOf('\mod_quiz\event\question_manually_graded', $event); + $this->assertEquals(context_module::instance($quizobj->get_cmid()), $event->get_context()); + $expected = array($quizobj->get_courseid(), 'quiz', 'manualgrade', 'comment.php?attempt=2&slot=3', + $quizobj->get_quizid(), $quizobj->get_cmid()); + $this->assertEventLegacyLogData($expected, $event); + $this->assertEventContextNotUsed($event); + } }