mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-15 21:45:37 +02:00
Code Issues Projects Releases Wiki Activity

MDL-38289: Custom profile fields - added unit test

Browse Source 
Added a unit test to cover the case when you are fetching a custom
profile field but you are not logged in.
This commit is contained in:
Damyon Wiese 2013-05-09 10:22:40 +08:00
parent 8cfc9d75ed
commit e9df9e8f7a
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/conditionlib.php
View File

@ -1325,7 +1325,7 @@ abstract class condition_info_base {
$iscurrentuser = $USER->id == $userid;
if (isguestuser($userid) || ($iscurrentuser && !isloggedin())) {
// Must be logged in and can't be the guest. (this should never happen anyway)
// Must be logged in and can't be the guest. (e.g. front page)
return false;
}

9
lib/tests/conditionlib_test.php
View File

@ -776,6 +776,15 @@ class conditionlib_testcase extends advanced_testcase {
// without error.
$ci->get_cached_user_profile_field($USER->id, $fieldid);
}
// Change to not logged in user.
$this->setUser(null);
foreach ($fields as $fieldid => $name) {
// Should get false always when not logged in.
$this->assertEquals(false, $ci->get_cached_user_profile_field($USER->id, $fieldid));
}
}
}