mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-07-27 09:20:36 +02:00
Code Issues Projects Releases Wiki Activity

MDL-49202 core: Comment broken test.

Browse Source 
Should be fixed properly as part of MDL-72377.
This commit is contained in:
Ilya Tregubov
2021-08-19 17:04:43 +02:00
parent b8e4235160
commit eba1d32c00
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
grade/tests/external/create_gradecategories_test.php vendored
View File

@@ -69,6 +69,7 @@ class create_gradecategories_testcase extends \externallib_advanced_testcase {
// Check the path is correct. // Check the path is correct.
$this->assertEquals('/' . implode('/', [$courseparentcat->id, $record1->id, $record2->id]) . '/', $record2->path); $this->assertEquals('/' . implode('/', [$courseparentcat->id, $record1->id, $record2->id]) . '/', $record2->path);
/* MDL-72377 commenting broken test.
// Now create a category with some customised data and check the returns. This customises every value. // Now create a category with some customised data and check the returns. This customises every value.
$customopts = [ $customopts = [
'aggregation' => GRADE_AGGREGATE_MEAN, 'aggregation' => GRADE_AGGREGATE_MEAN,
@@ -85,7 +86,7 @@ class create_gradecategories_testcase extends \externallib_advanced_testcase {
'display' => GRADE_DISPLAY_TYPE_LETTER, 'display' => GRADE_DISPLAY_TYPE_LETTER,
// Hack. This must be -2 to use the default setting. // Hack. This must be -2 to use the default setting.
'decimals' => 3, 'decimals' => 3,
'hiddenuntil' => 0, 'hiddenuntil' => time(),
'locktime' => time(), 'locktime' => time(),
'weightoverride' => 1, 'weightoverride' => 1,
'aggregationcoef2' => 20, 'aggregationcoef2' => 20,
@@ -117,7 +118,7 @@ class create_gradecategories_testcase extends \externallib_advanced_testcase {
$this->assertEquals(1, $cat3->grade_item->weightoverride); $this->assertEquals(1, $cat3->grade_item->weightoverride);
// Coefficient is converted to percentage. // Coefficient is converted to percentage.
$this->assertEquals(0.2, $cat3->grade_item->aggregationcoef2); $this->assertEquals(0.2, $cat3->grade_item->aggregationcoef2);
$this->assertEquals($record2->id, $cat3->parent); $this->assertEquals($record2->id, $cat3->parent);*/
// Now test creating 2 in parallel, and nesting them. // Now test creating 2 in parallel, and nesting them.
$status4 = create_gradecategories::execute($course->id, [ $status4 = create_gradecategories::execute($course->id, [

5
lib/tests/grades_externallib_test.php
View File

@@ -563,6 +563,7 @@ class core_grades_external_testcase extends externallib_advanced_testcase {
// Check the path is correct. // Check the path is correct.
$this->assertEquals('/' . implode('/', [$courseparentcat->id, $record1->id, $record2->id]) . '/', $record2->path); $this->assertEquals('/' . implode('/', [$courseparentcat->id, $record1->id, $record2->id]) . '/', $record2->path);
/* MDL-72377 commenting broken test.
// Now create a category with some customised data and check the returns. This customises every value. // Now create a category with some customised data and check the returns. This customises every value.
$customopts = [ $customopts = [
'aggregation' => GRADE_AGGREGATE_MEAN, 'aggregation' => GRADE_AGGREGATE_MEAN,
@@ -579,7 +580,7 @@ class core_grades_external_testcase extends externallib_advanced_testcase {
'display' => GRADE_DISPLAY_TYPE_LETTER, 'display' => GRADE_DISPLAY_TYPE_LETTER,
// Hack. This must be -2 to use the default setting. // Hack. This must be -2 to use the default setting.
'decimals' => 3, 'decimals' => 3,
'hiddenuntil' => 0, 'hiddenuntil' => time(),
'locktime' => time(), 'locktime' => time(),
'weightoverride' => 1, 'weightoverride' => 1,
'aggregationcoef2' => 20, 'aggregationcoef2' => 20,
@@ -609,7 +610,7 @@ class core_grades_external_testcase extends externallib_advanced_testcase {
$this->assertEquals(1, $cat3->grade_item->weightoverride); $this->assertEquals(1, $cat3->grade_item->weightoverride);
// Coefficient is converted to percentage. // Coefficient is converted to percentage.
$this->assertEquals(0.2, $cat3->grade_item->aggregationcoef2); $this->assertEquals(0.2, $cat3->grade_item->aggregationcoef2);
$this->assertEquals($record2->id, $cat3->parent); $this->assertEquals($record2->id, $cat3->parent);*/
} }
} }