Merge branch 'MDL-67412-master' of https://github.com/sharidas/moodle

lib/setuplib.php

@@ -618,24 +618,12 @@ function get_exception_info($ex) {
 }
 
 /**
- * Generate a V4 UUID.
- *
- * Unique is hard. Very hard. Attempt to use the PECL UUID function if available, and if not then revert to
- * constructing the uuid using mt_rand.
- *
- * It is important that this token is not solely based on time as this could lead
- * to duplicates in a clustered environment (especially on VMs due to poor time precision).
- *
- * @see https://tools.ietf.org/html/rfc4122
- *
  * @deprecated since Moodle 3.8 MDL-61038 - please do not use this function any more.
  * @see \core\uuid::generate()
- *
- * @return string The uuid.
  */
 function generate_uuid() {
-    debugging('generate_uuid() is deprecated. Please use \core\uuid::generate() instead.', DEBUG_DEVELOPER);
-    return \core\uuid::generate();
+    throw new coding_exception('generate_uuid() cannot be used anymore. Please use ' .
+        '\core\uuid::generate() instead.');
 }
 
 /**

lib/upgrade.txt

@@ -56,6 +56,8 @@ information provided here is intended especially for developers.
   - completion_completion::mark_complete()
   which is needed to store id of completion record on successful update which is later beeing used by
   completion_info::internal_set_data() to reaggregate completions that have been marked for instant course completion.
+* The following functions have been finally deprecated and can not be used anymore:
+  - generate_uuid
 
 === 3.11.2 ===
 * For security reasons, filelib has been updated so all requests now use emulated redirects.