mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-14 12:40:01 +01:00
Code Issues Projects Releases Wiki Activity

MDL-11347 adding comments with description of UPDATE related problems; minor whitespace and coding style changes

Browse Source
This commit is contained in:
skodak 2007-09-20 07:37:50 +00:00
parent 1dd3930b6c
commit ecbf2954da
1 changed files with 23 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
lib/accesslib.php
View File

@ -4431,31 +4431,40 @@ function build_context_path($force=false) {
'instanceid', SITEID);
}
$ctxemptyclause = " AND (ctx.depth IS NULL
$ctxemptyclause = " AND (ctx.depth IS NULL
OR ctx.depth=0) ";
$emptyclause = " AND ({$CFG->prefix}context.depth IS NULL
$emptyclause = " AND ({$CFG->prefix}context.depth IS NULL
OR {$CFG->prefix}context.depth=0) ";
if ($force) {
$ctxemptyclause = $emptyclause = '';
}
$updatesql = "UPDATE {$CFG->prefix}context
SET path = ct.path,
depth = ct.depth
FROM {$CFG->prefix}$temptable ct
WHERE ct.id={$CFG->prefix}context.id";
if ($CFG->dbfamily==='mysql') {
/* MDL-11347:
* - mysql does not allow to use FROM in UPDATE statements
* - using two tables after UPDATE works in mysql, but might give unexpected
* results in pg 8 (depends on configuration)
* - when using temporary table in mysql, it can be used only once in subselects
* - using table alias in UPDATE does not work in pg < 8.2
*/
if ($CFG->dbfamily == 'mysql') {
$updatesql = "UPDATE {$CFG->prefix}context, {$CFG->prefix}$temptable
SET {$CFG->prefix}context.path = {$CFG->prefix}$temptable.path,
{$CFG->prefix}context.depth = {$CFG->prefix}$temptable.depth
WHERE {$CFG->prefix}$temptable.id={$CFG->prefix}context.id";
SET {$CFG->prefix}context.path = {$CFG->prefix}$temptable.path,
{$CFG->prefix}context.depth = {$CFG->prefix}$temptable.depth
WHERE {$CFG->prefix}$temptable.id={$CFG->prefix}context.id";
} else {
$updatesql = "UPDATE {$CFG->prefix}context
SET path = ct.path,
depth = ct.depth
FROM {$CFG->prefix}$temptable ct
WHERE ct.id={$CFG->prefix}context.id";
}
$udelsql = "TRUNCATE TABLE {$CFG->prefix}$temptable";
// Top level categories
$sql = "UPDATE {$CFG->prefix}context
SET depth=2, path=" . sql_concat("'$base/'", 'id') . "
WHERE contextlevel=".CONTEXT_COURSECAT."
SET depth=2, path=" . sql_concat("'$base/'", 'id') . "
WHERE contextlevel=".CONTEXT_COURSECAT."
AND EXISTS (SELECT 'x'
FROM {$CFG->prefix}course_categories cc
WHERE cc.id = {$CFG->prefix}context.instanceid
@ -4545,7 +4554,7 @@ function build_context_path($force=false) {
WHERE contextlevel=".CONTEXT_USER."
AND EXISTS (SELECT 'x'
FROM {$CFG->prefix}user u
WHERE u.id = {$CFG->prefix}context.instanceid)
WHERE u.id = {$CFG->prefix}context.instanceid)
$emptyclause ";
execute_sql($sql, $force);