From ecf9a0c5a6c5c7c8642d2b6e6db380140b6b0149 Mon Sep 17 00:00:00 2001 From: Petr Skoda Date: Wed, 15 Jan 2014 12:02:00 +0800 Subject: [PATCH] MDL-41266 move reader access control out from manager We need to let reports decide if they want to use capability to access readers. --- admin/tool/log/classes/log/manager.php | 7 ++----- lib/classes/log/dummy_manager.php | 2 +- lib/classes/log/manager.php | 6 ++---- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/admin/tool/log/classes/log/manager.php b/admin/tool/log/classes/log/manager.php index 2399107dad6..efd0d9ba20c 100644 --- a/admin/tool/log/classes/log/manager.php +++ b/admin/tool/log/classes/log/manager.php @@ -94,16 +94,13 @@ class manager implements \core\log\manager { * * This way the reports find out available sources of data. * - * @param \context $context * @return \core\log\reader[] list of available log data readers */ - public function get_readers(\context $context) { + public function get_readers() { $this->init(); $return = array(); foreach ($this->readers as $plugin => $reader) { - if ($reader->can_access($context)) { - $return[$plugin] = $reader; - } + $return[$plugin] = $reader; } return $return; } diff --git a/lib/classes/log/dummy_manager.php b/lib/classes/log/dummy_manager.php index 6ca9ecf4b50..98d97987bea 100644 --- a/lib/classes/log/dummy_manager.php +++ b/lib/classes/log/dummy_manager.php @@ -28,7 +28,7 @@ namespace core\log; defined('MOODLE_INTERNAL') || die(); class dummy_manager implements manager { - public function get_readers(\context $context) { + public function get_readers() { return array(); } public function dispose() { diff --git a/lib/classes/log/manager.php b/lib/classes/log/manager.php index 1c40f92981d..d456165da73 100644 --- a/lib/classes/log/manager.php +++ b/lib/classes/log/manager.php @@ -36,13 +36,11 @@ defined('MOODLE_INTERNAL') || die(); */ interface manager { /** - * Return list of available log readers in given - * context for current user. + * Return list of available log readers. * - * @param \context $context * @return \core\log\reader[] */ - public function get_readers(\context $context); + public function get_readers(); /** * Dispose all initialised stores.