From ee9e7ee31df60117ec35c1441e3a2fd45bc2ba25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Mudr=C3=A1k?= Date: Wed, 3 May 2017 21:28:23 +0200 Subject: [PATCH] MDL-58749 lang: Change "inline text" to "online text" in qtype_essay This change has been agreed by Helen and Tim in MDL-49208. --- question/type/essay/db/install.xml | 2 +- question/type/essay/question.php | 2 +- question/type/essay/tests/behat/edit.feature | 4 ++-- question/type/essay/tests/helper.php | 2 +- question/type/essay/tests/question_test.php | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/question/type/essay/db/install.xml b/question/type/essay/db/install.xml index eb1fc2d54a3..b7abfbd2995 100644 --- a/question/type/essay/db/install.xml +++ b/question/type/essay/db/install.xml @@ -9,7 +9,7 @@ - + diff --git a/question/type/essay/question.php b/question/type/essay/question.php index a14b06ab759..2720e1505bf 100644 --- a/question/type/essay/question.php +++ b/question/type/essay/question.php @@ -91,7 +91,7 @@ class qtype_essay_question extends question_with_responses { } public function is_complete_response(array $response) { - // Determine if the given response has inline text and attachments. + // Determine if the given response has online text and attachments. $hasinlinetext = array_key_exists('answer', $response) && ($response['answer'] !== ''); $hasattachments = array_key_exists('attachments', $response) && $response['attachments'] instanceof question_response_files; diff --git a/question/type/essay/tests/behat/edit.feature b/question/type/essay/tests/behat/edit.feature index 709e51af7a5..52b022237a0 100644 --- a/question/type/essay/tests/behat/edit.feature +++ b/question/type/essay/tests/behat/edit.feature @@ -34,9 +34,9 @@ Feature: Test editing an Essay question Then I should see "You must supply a value here." When I set the following fields to these values: | Question name | Edited essay-001 name | - | Response format | No inline text | + | Response format | No online text | And I press "id_submitbutton" - Then I should see "When \"no inline text\" is selected, or responses are optional, you must allow at least one attachment." + Then I should see "When \"No online text\" is selected, or responses are optional, you must allow at least one attachment." When I set the following fields to these values: | Response format | Plain text | And I press "id_submitbutton" diff --git a/question/type/essay/tests/helper.php b/question/type/essay/tests/helper.php index c63668495eb..07dd4e06ca7 100644 --- a/question/type/essay/tests/helper.php +++ b/question/type/essay/tests/helper.php @@ -183,7 +183,7 @@ class qtype_essay_test_helper extends question_test_helper { } /** - * Makes an essay question without an inline text editor. + * Makes an essay question without an online text editor. * @return qtype_essay_question */ public function make_essay_question_noinline() { diff --git a/question/type/essay/tests/question_test.php b/question/type/essay/tests/question_test.php index 6ab9635e382..2ac7e1661dd 100644 --- a/question/type/essay/tests/question_test.php +++ b/question/type/essay/tests/question_test.php @@ -200,7 +200,7 @@ class qtype_essay_question_test extends advanced_testcase { $this->assertTrue($essay->is_complete_response( array('answer' => '', 'attachments' => $attachments[2]))); - // Test the case in which both the response and inline text are optional. + // Test the case in which both the response and online text are optional. $essay->attachmentsrequired = 0; // Providing no answer and no attachment should result in an incomplete