MDL-32003 protect xmldb class internals

Use getters and setters instead!

lib/xmldb/xmldb_field.php

@@ -29,22 +29,22 @@ defined('MOODLE_INTERNAL') || die();
 class xmldb_field extends xmldb_object {
 
     /** @var int XMLDB_TYPE_ constants */
-    var $type;
+    protected $type;
 
     /** @var int size of field */
-    var $length;
+    protected $length;
 
     /** @var bool is null forbidden? XMLDB_NOTNULL */
-    var $notnull;
+    protected $notnull;
 
     /** @var mixed default value */
-    var $default;
+    protected $default;
 
     /** @var bool use automatic counter */
-    var $sequence;
+    protected $sequence;
 
     /** @var int number of decimals */
-    var $decimals;
+    protected $decimals;
 
     /**
      * Note:

lib/xmldb/xmldb_file.php

@@ -29,16 +29,16 @@ defined('MOODLE_INTERNAL') || die();
 class xmldb_file extends xmldb_object {
 
     /** @var string path to file */
-    var $path;
+    protected $path;
 
     /** @var string path to schema */
-    var $schema;
+    protected $schema;
 
     /** @var  string document dtd */
-    var $dtd;
+    protected $dtd;
 
     /** @var xmldb_structure the structure stored in file */
-    var $xmldb_structure;
+    protected $xmldb_structure;
 
     /**
      * Constructor of the xmldb_file

lib/xmldb/xmldb_index.php

@@ -29,10 +29,10 @@ defined('MOODLE_INTERNAL') || die();
 class xmldb_index extends xmldb_object {
 
     /** @var bool is unique? */
-    var $unique;
+    protected $unique;
 
     /** @var array index fields */
-    var $fields;
+    protected $fields;
 
     /**
      * Note:

lib/xmldb/xmldb_key.php

@@ -29,16 +29,16 @@ defined('MOODLE_INTERNAL') || die();
 class xmldb_key extends xmldb_object {
 
     /** @var int type of key */
-    var $type;
+    protected $type;
 
     /** @var array of fields */
-    var $fields;
+    protected $fields;
 
     /** @var string referenced table */
-    var $reftable;
+    protected $reftable;
 
     /** @var array referenced fields */
-    var $reffields;
+    protected $reffields;
 
     /**
      * Creates one new xmldb_key

lib/xmldb/xmldb_object.php

@@ -29,28 +29,28 @@ defined('MOODLE_INTERNAL') || die();
 class xmldb_object {
 
     /** @var string name of obejct */
-    var $name;
+    protected $name;
 
     /** @var string comment on object */
-    var $comment;
+    protected $comment;
 
     /** @var xmldb_object */
-    var $previous;
+    protected $previous;
 
     /** @var xmldb_object */
-    var $next;
+    protected $next;
 
     /** @var string hash of object */
-    var $hash;
+    protected $hash;
 
     /** @var bool is it loaded yet */
-    var $loaded;
+    protected $loaded;
 
     /** @var bool was object changed */
-    var $changed;
+    protected $changed;
 
     /** @var string error message */
-    var $errormsg;
+    protected $errormsg;
 
     /**
      * Creates one new xmldb_object

lib/xmldb/xmldb_structure.php

@@ -29,13 +29,13 @@ defined('MOODLE_INTERNAL') || die();
 class xmldb_structure extends xmldb_object {
 
     /** @var string */
-    var $path;
+    protected $path;
 
     /** @var string */
-    var $version;
+    protected $version;
 
     /** @var array tables */
-    var $tables;
+    protected $tables;
 
     /**
      * Creates one new xmldb_structure

lib/xmldb/xmldb_table.php

@@ -29,13 +29,13 @@ defined('MOODLE_INTERNAL') || die();
 class xmldb_table extends xmldb_object {
 
     /** @var array table columns */
-    var $fields;
+    protected $fields;
 
     /** @var array keys */
-    var $keys;
+    protected $keys;
 
     /** @var array indexes */
-    var $indexes;
+    protected $indexes;
 
     /**
      * Note: