mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 22:08:20 +01:00
Code Issues Projects Releases Wiki Activity

MDL-48104 mod_assign: Strip out use of eval() for string parsing

Browse Source 
I've also replaced other  occurrences of M.str with the correct use of
M.util.get_string() instead.
This commit is contained in:
Andrew Nicols 2014-11-17 14:55:19 +08:00 committed by Dan Poltawski
parent a2c5d58e93
commit f06fc2b5c4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mod/assign/module.js
View File

@ -79,7 +79,7 @@ M.mod_assign.init_grading_table = function(Y) {
usersinput = Y.one('input.selectedusers');
usersinput.set('value', selectedusers.join(','));
if (selectedusers.length == 0) {
alert(M.str.assign.nousersselected);
alert(M.util.get_string('nousersselected', 'assign'));
e.preventDefault();
} else {
action = operation.get('value');
@ -88,9 +88,9 @@ M.mod_assign.init_grading_table = function(Y) {
pluginaction = action.substr(prefix.length);
plugin = pluginaction.split('_')[0];
action = pluginaction.substr(plugin.length + 1);
confirmmessage = eval('M.str.assignfeedback_' + plugin + '.batchoperationconfirm' + action);
confirmmessage = M.util.get_string('batchoperationconfirm' + action, 'assignfeedback_' + plugin);
} else {
confirmmessage = eval('M.str.assign.batchoperationconfirm' + operation.get('value'));
confirmmessage = M.util.get_string('batchoperationconfirm' + operation.get('value'), 'assign');
}
if (!confirm(confirmmessage)) {
e.preventDefault();
@ -153,7 +153,7 @@ M.mod_assign.init_grade_change = function(Y) {
var originalvalue = gradenode.get('value');
gradenode.on('change', function() {
if (gradenode.get('value') != originalvalue) {
alert(M.str.mod_assign.changegradewarning);
alert(M.util.get_string('changegradewarning', 'mod_assign'));
}
});
}