mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 22:08:20 +01:00
Code Issues Projects Releases Wiki Activity

MDL-76109 core: Don't check password policy for guest user

Browse Source 
Besides adding the is_guest() check in the check_password_policy() condition,
I also changed the temporary user ID because the temporary user and
the guest must not share the same ID. Otherwise, it will raise an error.

Co-authored-by: Andrei Bautu <abautu@gmail.com>
This commit is contained in:
Meirza 2023-11-29 21:38:41 +07:00
parent b1bb5671df
commit f16b42d013
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/authlib.php
View File

@ -1113,7 +1113,9 @@ function signup_validate_data($data, $files) {
// Construct fake user object to check password policy against required information.
$tempuser = new stdClass();
$tempuser->id = 1;
// To prevent errors with check_password_policy(),
// the temporary user and the guest must not share the same ID.
$tempuser->id = (int)$CFG->siteguest + 1;
$tempuser->username = $data['username'];
$tempuser->firstname = $data['firstname'];
$tempuser->lastname = $data['lastname'];

2
lib/moodlelib.php
View File

@ -4966,7 +4966,7 @@ function get_complete_user_data($field, $value, $mnethostid = null, $throwexcept
function check_password_policy($password, &$errmsg, $user = null) {
global $CFG;
if (!empty($CFG->passwordpolicy)) {
if (!empty($CFG->passwordpolicy) && !isguestuser($user)) {
$errmsg = '';
if (core_text::strlen($password) < $CFG->minpasswordlength) {
$errmsg .= '<div>'. get_string('errorminpasswordlength', 'auth', $CFG->minpasswordlength) .'</div>';