From f2c780d525b717c32668221d37828b5cd1808331 Mon Sep 17 00:00:00 2001 From: Andrew Nicols Date: Fri, 13 Dec 2013 11:05:36 +0800 Subject: [PATCH] MDL-34182 AJAX: Change to use shared method when checking the siteadminbranch for invalid output --- lib/ajax/getsiteadminbranch.php | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/lib/ajax/getsiteadminbranch.php b/lib/ajax/getsiteadminbranch.php index 9f7d9405787..459d1c388a5 100644 --- a/lib/ajax/getsiteadminbranch.php +++ b/lib/ajax/getsiteadminbranch.php @@ -40,7 +40,7 @@ if ($branchtype !== navigation_node::TYPE_SITE_ADMIN) { } // Start capturing output in case of broken plugins. -ob_start(); +ajax_capture_output(); $PAGE->set_context(context_system::instance()); $PAGE->set_url('/lib/ajax/getsiteadminbranch.php', array('type'=>$branchtype)); @@ -51,12 +51,5 @@ $sitenavigation = new settings_navigation_ajax($PAGE); $converter = new navigation_json(); $branch = $sitenavigation->get('root'); -$output = ob_get_contents(); -ob_end_clean(); -if ($CFG->debugdeveloper && !empty($output)) { - throw new coding_exception('Unexpected output whilst building the administration tree. ' . - 'This could be caused by trailing whitespace. Output received: ' . - var_export($output, true)); -} else { - echo $converter->convert($branch); -} +ajax_check_captured_output(); +echo $converter->convert($branch);