mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-16785 bogus grades inserted when formulas used - credit Michael Spall and Ann Adamcik; merged from MOODLE_19_STABLE

Browse Source
This commit is contained in:
skodak 2008-10-24 17:53:15 +00:00
parent 35da0e8768
commit f53db007f6
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/grade/grade_item.php
View File

@ -1636,14 +1636,14 @@ class grade_item extends grade_object {
}
// precreate grades - we need them to exist
$params = array($this->id);
$params = array($this->courseid, $this->id, $this->id);
$sql = "SELECT DISTINCT go.userid
FROM {grade_grades} go
JOIN {grade_items} gi
ON gi.id = go.itemid
ON (gi.id = go.itemid AND gi.courseid = ?)
LEFT OUTER JOIN {grade_grades} g
ON (g.userid = go.userid AND g.itemid = ?)
WHERE gi.id <> $this->id AND g.id IS NULL";
WHERE gi.id <> ? AND g.id IS NULL";
if ($missing = $DB->get_records_sql($sql, $params)) {
foreach ($missing as $m) {
$grade = new grade_grade(array('itemid'=>$this->id, 'userid'=>$m->userid), false);