mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-13 12:32:08 +02:00
Code Issues Projects Releases Wiki Activity

MDL-56511 theme_boost: Fixing minor behat failures

Browse Source 
Related to MDL-56511 markup changes.
This commit is contained in:
David Monllao 2018-04-18 13:52:58 +02:00 committed by Eloy Lafuente (stronk7)
parent baf8ff9cbf
commit f5779bb101
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
auth/tests/behat/displayloginfailures.feature
View File

@ -25,11 +25,11 @@ Feature: Test the 'showlogfailures' feature works.
And I set the field "Password" to "teacher1"
And I press "Log in"
# Confirm the notices are displayed.
Then I should see "1 failed logins since your last login" in the "header.navbar" "css_element"
Then I should see "1 failed logins since your last login" in the "nav.navbar" "css_element"
And I should see "1 failed logins since your last login" in the "page-footer" "region"
# Confirm the notices disappear when navigating to another page.
And I am on homepage
And I should not see "1 failed logins since your last login" in the "header.navbar" "css_element"
And I should not see "1 failed logins since your last login" in the "nav.navbar" "css_element"
And I should not see "1 failed logins since your last login" in the "page-footer" "region"
# Given the user has at least one failed login attempt, when they login, then they should see both header and footer notices.
@ -46,10 +46,10 @@ Feature: Test the 'showlogfailures' feature works.
And I set the field "Password" to "admin"
And I press "Log in"
# Confirm the notices are displayed.
Then I should see "1 failed logins since your last login" in the "header.navbar" "css_element"
Then I should see "1 failed logins since your last login" in the "nav.navbar" "css_element"
And I should see "1 failed logins since your last login (Logs)" in the "page-footer" "region"
# Confirm that the link works and that the notices disappear when navigating to another page.
And I click on "Logs" "link" in the "page-footer" "region"
And I should see "User login failed" in the "table.reportlog" "css_element"
And I should not see "1 failed logins since your last login" in the "header.navbar" "css_element"
And I should not see "1 failed logins since your last login" in the "nav.navbar" "css_element"
And I should not see "1 failed logins since your last login (Logs)" in the "page-footer" "region"

2
theme/boost/templates/navbar.mustache
View File

@ -51,7 +51,7 @@
{{{ output.navbar_plugin_output }}}
</li>
<!-- user_menu -->
<li class="nav-item d-flex align-items-center usermenu">
<li class="nav-item d-flex align-items-center">
{{{ output.user_menu }}}
</li>
</ul>

2
theme/boost/tests/behat/behat_theme_boost_behat_navigation.php
View File

@ -40,7 +40,7 @@ class behat_theme_boost_behat_navigation extends behat_navigation {
if ($this->running_javascript()) {
// The user menu must be expanded when JS is enabled.
$xpath = "//li[contains(concat(' ', @class, ' '), ' usermenu ')]//a[contains(concat(' ', @class, ' '), ' dropdown-toggle ')]";
$xpath = "//div[contains(concat(' ', @class, ' '), ' usermenu ')]//a[contains(concat(' ', @class, ' '), ' dropdown-toggle ')]";
$this->execute("behat_general::i_click_on", array($this->escape($xpath), "xpath_element"));
}