mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-13 20:42:22 +02:00
Code Issues Projects Releases Wiki Activity

MDL-31192 core_webservice: do not render div inside span

Browse Source 
`<span>` tags only permit "phrasing content" but `<div>` (and also the
`<ins>` tag) are flow content. So, switching to div all along.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
This commit is contained in:
Daniel Ziegenberg 2022-11-24 23:09:31 +01:00
parent ad7fc69c25
commit f69b0e189c
No known key found for this signature in database
GPG Key ID: 7E6F98FFADBEFD39
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
webservice/renderer.php
View File

@ -565,7 +565,6 @@ EOF;
* @return string HTML code
*/
public function colored_box_with_pre_tag($title, $content, $rgb = 'FEEBE5') {
//TODO MDL-31192 this tag removes xhtml strict error but cause warning
$coloredbox = html_writer::start_tag('div', array());
$coloredbox .= html_writer::start_tag('div',
array('style' => "border:solid 1px #DEDEDE;background:#" . $rgb
@ -706,7 +705,7 @@ EOF;
$documentationhtml .= $br;
foreach ($description->parameters_desc->keys as $paramname => $paramdesc) {
// a argument documentation
$documentationhtml .= html_writer::start_tag('span', array('style' => 'font-size:80%'));
$documentationhtml .= html_writer::start_tag('div', ['style' => 'font-size:80%']);
if ($paramdesc->required == VALUE_REQUIRED) {
$required = get_string('required', 'webservice');
@ -752,7 +751,7 @@ EOF;
$paramdesc, $paramname), ENT_COMPAT),
'FEEBE5');
}
$documentationhtml .= html_writer::end_tag('span');
$documentationhtml .= html_writer::end_tag('div');
}
$documentationhtml .= $br . $br;
@ -763,7 +762,7 @@ EOF;
$documentationhtml .= html_writer::end_tag('span');
$documentationhtml .= $br;
// function response description
$documentationhtml .= html_writer::start_tag('span', array('style' => 'font-size:80%'));
$documentationhtml .= html_writer::start_tag('div', ['style' => 'font-size:80%']);
if (!empty($description->returns_desc->desc)) {
$documentationhtml .= $description->returns_desc->desc;
$documentationhtml .= $br . $br;
@ -795,7 +794,7 @@ EOF;
'FEEBE5');
}
}
$documentationhtml .= html_writer::end_tag('span');
$documentationhtml .= html_writer::end_tag('div');
$documentationhtml .= $br . $br;
// function errors documentation for REST protocol
@ -804,7 +803,7 @@ EOF;
$documentationhtml .= get_string('errorcodes', 'webservice');
$documentationhtml .= html_writer::end_tag('span');
$documentationhtml .= $br . $br;
$documentationhtml .= html_writer::start_tag('span', array('style' => 'font-size:80%'));
$documentationhtml .= html_writer::start_tag('div', ['style' => 'font-size:80%']);
$errormessage = get_string('invalidparameter', 'debug');
$restexceptiontext = <<<EOF
<?xml version="1.0" encoding="UTF-8"?>
@ -818,7 +817,7 @@ EOF;
htmlentities($restexceptiontext, ENT_COMPAT),
'FEEBE5');
$documentationhtml .= html_writer::end_tag('span');
$documentationhtml .= html_writer::end_tag('div');
}
$documentationhtml .= $br . $br;